From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F33EC433FE for ; Tue, 15 Feb 2022 21:28:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243431AbiBOV2e (ORCPT ); Tue, 15 Feb 2022 16:28:34 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233069AbiBOV2d (ORCPT ); Tue, 15 Feb 2022 16:28:33 -0500 X-Greylist: delayed 1885 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 15 Feb 2022 13:28:21 PST Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA51CC24A9; Tue, 15 Feb 2022 13:28:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=keg/iMk+UdaNfyy0BZm+iDOzuvq0G4cjTusXA9Hp92k=; b=CAkseX/Qyh+FIx8oj8t3veXNKf UKyx6v1rPPeE7gNSMBgBfKGoC0Yi6enZ8NhlM1sTilCU+NodZ4d8ft4POAS992JSNuPDdt6ZG8am+ w+FwWzbH0q1dp0OqCSHkFnaLXFtmo/c81EZlMzbsdwPVNZ/IfR35QWsvVNInmaVq9sSE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nK4sU-0067XH-Bw; Tue, 15 Feb 2022 21:56:50 +0100 Date: Tue, 15 Feb 2022 21:56:50 +0100 From: Andrew Lunn To: Oleksij Rempel Cc: Marc Kleine-Budde , Tony Lindgren , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, Jakub Kicinski , devicetree@vger.kernel.org, Nicolas Saenz Julienne , =?iso-8859-1?Q?Beno=EEt?= Cousson , Ray Jui , Sascha Hauer , Rob Herring , linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, Florian Fainelli , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Scott Branden , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Shawn Guo , "David S. Miller" Subject: Re: [PATCH v3 5/8] ARM: dts: exynos: fix ethernet node name for different odroid boards Message-ID: References: <20220215080937.2263111-1-o.rempel@pengutronix.de> <20220215080937.2263111-5-o.rempel@pengutronix.de> <20220215081240.hhie4niqnc5tuka2@pengutronix.de> <20220215081645.GD672@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220215081645.GD672@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org > > > - ethernet: usbether@2 { > > > - compatible = "usb0424,9730"; > > > + ethernet: ethernet@2 { > > > + compatible = "usb424,9730"; > > > > The change of the compatible is not mentioned in the patch description. > > Is this intentional? > > No, I forgot to mentione it. According to the USB schema 0 should be > removed. So, this compatible was incorrect as well. With leading zero > present yaml schema was not able to detect and validate this node. Does the current code not actually care about a leading 0? It will match with or without it? It would be good to mention that as well in the commit message, otherwise somebody like me is going to ask if this breaks backwards compatibility, since normally compatible is an exact string match. And i actually think this is the sort of change which should be as a patch of its own. If this causes a regression, a git bisect would then tell you if it is the change of usbether -> ethernet, or 0424 to 424. That is part of why we ask for lots of small changes. Andrew