From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sandipan Patra <spatra@nvidia.com>
Cc: treding@nvidia.com, jonathanh@nvidia.com, digetx@gmail.com,
ulf.hansson@linaro.org, cai.huoqing@linux.dev, bbasu@nvidia.com,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc/tegra: pmc: update Tegra234 reset sources
Date: Wed, 30 Mar 2022 12:16:07 +0300 [thread overview]
Message-ID: <YkQf13VH7RzrEcG/@smile.fi.intel.com> (raw)
In-Reply-To: <20220330063635.1689-1-spatra@nvidia.com>
On Wed, Mar 30, 2022 at 12:06:35PM +0530, Sandipan Patra wrote:
> Reset_sources list is updated to add all reset sources
> and removing ones that do not actually exist.
...
> + "SYS_RESET_N", /*0*/
Missed spaces in the comment here and everywhere else.
Not sure about indices. If it's going to be a part of the hardware programming
interface it may make sense to use hexadecimal rather than decimal.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-30 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 6:36 [PATCH] soc/tegra: pmc: update Tegra234 reset sources Sandipan Patra
2022-03-30 9:16 ` Andy Shevchenko [this message]
2022-04-01 10:12 ` Sandipan Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkQf13VH7RzrEcG/@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bbasu@nvidia.com \
--cc=cai.huoqing@linux.dev \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=spatra@nvidia.com \
--cc=treding@nvidia.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox