From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48EF2C433EF for ; Wed, 30 Mar 2022 09:16:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244697AbiC3JSc (ORCPT ); Wed, 30 Mar 2022 05:18:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244706AbiC3JS2 (ORCPT ); Wed, 30 Mar 2022 05:18:28 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9431F25C54; Wed, 30 Mar 2022 02:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648631803; x=1680167803; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=u/cy2/AdvnF64CBs9i/0Wl3P9S34F9SVM/vWq+6wsTA=; b=NPTT8I1Xz1VMzQN2bmpMTKcjLZlR+YfEA2WRlf7jZAaqtd55xyGuA6bY huBwlpYek/EvKVeEMwhjiarwQds1DFw1raugtRbGHZuKPukWLA7TnyxAZ g7SkN8WdTuvjtJP1d6/hUwVYH174YP3Aqi1SNJ0cL/AEY72/QmUDGHfzM flWOWn+6Ku/Ox0rtp4iHQuS8n5zBZAmNf6ZWQXb7CS9rMAd0YB54vZJod u0Mw7QrCwn/p1m6l+gJB2ucxC4qmodZqDBcJ+Eys5Yrxhoog7LTyy84Df ud6SG3mFj0QtDYxOlDmNWRb2+6VAqEKf56ZE2ZsaSlnh1mtsmZhtPmIT9 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="259467214" X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="259467214" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 02:16:43 -0700 X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="503244616" Received: from smile.fi.intel.com ([10.237.72.59]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 02:16:40 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nZUQx-009IxE-H9; Wed, 30 Mar 2022 12:16:07 +0300 Date: Wed, 30 Mar 2022 12:16:07 +0300 From: Andy Shevchenko To: Sandipan Patra Cc: treding@nvidia.com, jonathanh@nvidia.com, digetx@gmail.com, ulf.hansson@linaro.org, cai.huoqing@linux.dev, bbasu@nvidia.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc/tegra: pmc: update Tegra234 reset sources Message-ID: References: <20220330063635.1689-1-spatra@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220330063635.1689-1-spatra@nvidia.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Wed, Mar 30, 2022 at 12:06:35PM +0530, Sandipan Patra wrote: > Reset_sources list is updated to add all reset sources > and removing ones that do not actually exist. ... > + "SYS_RESET_N", /*0*/ Missed spaces in the comment here and everywhere else. Not sure about indices. If it's going to be a part of the hardware programming interface it may make sense to use hexadecimal rather than decimal. -- With Best Regards, Andy Shevchenko