Re: [PATCH v2] clk: tegra: Add missing reset deassertion

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]

On Fri, Apr 29, 2022 at 01:58:43PM +0100, Diogo Ivo wrote:
> Commit 4782c0a5dd88e3797426e08c5c437e95a3156631 ("clk: tegra: Don't
> deassert reset on enabling clocks") removed deassertion of reset lines
> when enabling peripheral clocks. This breaks the initialization of the
> DFLL driver which relied on this behaviour.
> 
> Fix this problem by adding explicit deassert/assert requests to the
> driver and the corresponding reset to the DT. Tested on Google Pixel C.
> 
> Cc: stable@vger.kernel.org
> Fixes: 4782c0a5dd88 ("clk: tegra: Don't deassert reset on enabling clocks")
> Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
> ---
> Changes in v2:
>  - Changed reset getter to the optional variant
> 
>  arch/arm64/boot/dts/nvidia/tegra210.dtsi |  5 +++--
>  drivers/clk/tegra/clk-dfll.c             | 12 ++++++++++++
>  2 files changed, 15 insertions(+), 2 deletions(-)

I've applied this, but in the process split it up into two: one patch
for the clock driver and another for the device tree changes. For future
patches, please keep in mind that driver and device tree changes should
always be separate.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]