From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D98B0C433EF for ; Thu, 16 Jun 2022 08:43:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359713AbiFPInF (ORCPT ); Thu, 16 Jun 2022 04:43:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359695AbiFPInE (ORCPT ); Thu, 16 Jun 2022 04:43:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCDF7FC1; Thu, 16 Jun 2022 01:43:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6E973B81E20; Thu, 16 Jun 2022 08:43:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AF60C34114; Thu, 16 Jun 2022 08:43:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655368981; bh=254RCbxo4FfZtCOL3JaXO+g0LVlpONTzvmsMgyFher8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NMawHAL2CRg6wix7iwPCHkoIrl8oFmn1vWzHiUp2QxVXetAEvnKnMutMYJijrejj1 GwGtIScIfvKZ33v8HeW+NtmYmz/gcJuskYLzZ6okPtBQyP1UtS3ps3UUf4KWwsladG KYrPNhMn1OorOiXskAay3GozWO3k4NGFNBvtqGEM= Date: Thu, 16 Jun 2022 10:42:57 +0200 From: Greg KH To: Dave Airlie Cc: heliang , linux-serial@vger.kernel.org, linux-tegra@vger.kernel.org, Linux Media Mailing List , dri-devel Subject: Re: [Linaro-mm-sig] Re: [PATCH] drivers: tty: serial: Add missing of_node_put() in serial-tegra.c Message-ID: References: <20220615104833.3963552-1-windhl@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Thu, Jun 16, 2022 at 06:23:26AM +1000, Dave Airlie wrote: > On Wed, 15 Jun 2022 at 20:53, Greg KH wrote: > > > > On Wed, Jun 15, 2022 at 06:48:33PM +0800, heliang wrote: > > > In tegra_uart_init(), of_find_matching_node() will return a node > > > pointer with refcount incremented. We should use of_node_put() > > > when it is not used anymore. > > > > > > Signed-off-by: heliang > > > > We need a real name please, one you sign documents with. > > How do we enforce that? What if Wong, Adele or Beyonce submit a patch? As per our rules in the kernel, we can not accept a signed-off-by by a known anonymous person. When you can obviously see that the name is incorrect (as has happened recently with different names being used for the from: and the s-o-b lines in the email address), you have to ask for clarification. It's something that all maintainers should be doing. > What happens if that patch gets reposted, with S-o-b: He Liang > or Hel Iang, Heli Ang? Do you know any of those are > real names? What happens if they post a real name in > Mandarin/Thai/Cyrillic, can you validate it? I would love for people to use their names in their native language, there's no need to make up english-sounding names at all. We have many examples of this in commits already, I would be happy if we get more. And yes, validating names in those languages is usually not very difficult. thanks, greg k-h