From: Thierry Reding <thierry.reding@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jon Hunter <jonathanh@nvidia.com>,
Prathamesh Shete <pshete@nvidia.com>,
Vidya Sagar <vidyas@nvidia.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: pinctrl: tegra194: Separate instances
Date: Mon, 4 Jul 2022 19:02:28 +0200 [thread overview]
Message-ID: <YsMdJFp+NZoSOTZI@orome> (raw)
In-Reply-To: <20220701211925.GA1550339-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]
On Fri, Jul 01, 2022 at 03:19:25PM -0600, Rob Herring wrote:
> On Fri, Jul 01, 2022 at 05:04:59PM +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Tegra194 has two separate instances of the pin controller, one called
> > AON (in the always-on domain) and another called "main". Instead of
> > treating them as a single pin controller, split them up into two
> > separate controllers. Doing so allows the mapping between the pinmux and
> > GPIO controllers to be trivial identity mappings and more cleanly
> > separates the AON from the main IP blocks.
>
> Doesn't this break compatibility?
I had added this paragraph to the cover letter:
Note that while this changes the DT node in an incompatible way, this
doesn't have any practical implications for backwards-compatibility. The
reason for this is that device trees have only reconfigured a very
narrow subset of pins of the main controller, so the new driver will
remain backwards-compatible with old device trees.
I've now added that to the commit message of this patch in v2 to
hopefully clarify that for posterity.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-07-04 17:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 15:04 [PATCH 0/4] pinctrl: tegra: Separate Tegra194 instances Thierry Reding
2022-07-01 15:04 ` [PATCH 1/4] dt-bindings: pinctrl: tegra: Convert to json-schema Thierry Reding
2022-07-01 21:17 ` Rob Herring
2022-07-04 17:01 ` Thierry Reding
2022-07-04 17:10 ` Thierry Reding
2022-07-01 15:04 ` [PATCH 2/4] dt-bindings: pinctrl: tegra194: Separate instances Thierry Reding
2022-07-01 21:19 ` Rob Herring
2022-07-04 17:02 ` Thierry Reding [this message]
2022-07-01 15:05 ` [PATCH 3/4] pinctrl: tegra: Separate Tegra194 instances Thierry Reding
2022-07-01 15:05 ` [PATCH 4/4] arm64: tegra: Separate AON pinmux from main pinmux on Tegra194 Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsMdJFp+NZoSOTZI@orome \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pshete@nvidia.com \
--cc=robh@kernel.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).