* [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts
@ 2024-12-15 21:47 linux
2024-12-17 7:24 ` Mikko Perttunen
2025-02-28 16:46 ` Thierry Reding
0 siblings, 2 replies; 5+ messages in thread
From: linux @ 2024-12-15 21:47 UTC (permalink / raw)
To: thierry.reding, mperttunen, linux-tegra
Cc: airlied, simona, dri-devel, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
host1x_debug_dump_syncpts() has been unused since
commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA
fences")
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/gpu/host1x/debug.c | 9 ---------
drivers/gpu/host1x/debug.h | 1 -
2 files changed, 10 deletions(-)
diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c
index a18cc8d8caf5..6433c00d5d7e 100644
--- a/drivers/gpu/host1x/debug.c
+++ b/drivers/gpu/host1x/debug.c
@@ -216,12 +216,3 @@ void host1x_debug_dump(struct host1x *host1x)
show_all(host1x, &o, true);
}
-
-void host1x_debug_dump_syncpts(struct host1x *host1x)
-{
- struct output o = {
- .fn = write_to_printk
- };
-
- show_syncpts(host1x, &o, false);
-}
diff --git a/drivers/gpu/host1x/debug.h b/drivers/gpu/host1x/debug.h
index 62bd8a091fa7..c43c61d876a9 100644
--- a/drivers/gpu/host1x/debug.h
+++ b/drivers/gpu/host1x/debug.h
@@ -41,6 +41,5 @@ extern unsigned int host1x_debug_trace_cmdbuf;
void host1x_debug_init(struct host1x *host1x);
void host1x_debug_deinit(struct host1x *host1x);
void host1x_debug_dump(struct host1x *host1x);
-void host1x_debug_dump_syncpts(struct host1x *host1x);
#endif
--
2.47.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts
2024-12-15 21:47 [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts linux
@ 2024-12-17 7:24 ` Mikko Perttunen
2025-02-28 15:48 ` Dr. David Alan Gilbert
2025-02-28 16:46 ` Thierry Reding
1 sibling, 1 reply; 5+ messages in thread
From: Mikko Perttunen @ 2024-12-17 7:24 UTC (permalink / raw)
To: linux, thierry.reding, mperttunen, linux-tegra
Cc: airlied, simona, dri-devel, linux-kernel
On 12/16/24 6:47 AM, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> host1x_debug_dump_syncpts() has been unused since
> commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA
> fences")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> drivers/gpu/host1x/debug.c | 9 ---------
> drivers/gpu/host1x/debug.h | 1 -
> 2 files changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c
> index a18cc8d8caf5..6433c00d5d7e 100644
> --- a/drivers/gpu/host1x/debug.c
> +++ b/drivers/gpu/host1x/debug.c
> @@ -216,12 +216,3 @@ void host1x_debug_dump(struct host1x *host1x)
>
> show_all(host1x, &o, true);
> }
> -
> -void host1x_debug_dump_syncpts(struct host1x *host1x)
> -{
> - struct output o = {
> - .fn = write_to_printk
> - };
> -
> - show_syncpts(host1x, &o, false);
> -}
> diff --git a/drivers/gpu/host1x/debug.h b/drivers/gpu/host1x/debug.h
> index 62bd8a091fa7..c43c61d876a9 100644
> --- a/drivers/gpu/host1x/debug.h
> +++ b/drivers/gpu/host1x/debug.h
> @@ -41,6 +41,5 @@ extern unsigned int host1x_debug_trace_cmdbuf;
> void host1x_debug_init(struct host1x *host1x);
> void host1x_debug_deinit(struct host1x *host1x);
> void host1x_debug_dump(struct host1x *host1x);
> -void host1x_debug_dump_syncpts(struct host1x *host1x);
>
> #endif
Acked-by: Mikko Perttunen <mperttunen@nvidia.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts
2024-12-17 7:24 ` Mikko Perttunen
@ 2025-02-28 15:48 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2025-02-28 15:48 UTC (permalink / raw)
To: airlied, simona, tzimmermann
Cc: Mikko Perttunen, thierry.reding, mperttunen, linux-tegra,
dri-devel, linux-kernel
Hi,
* Mikko Perttunen (cyndis@kapsi.fi) wrote:
> On 12/16/24 6:47 AM, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > host1x_debug_dump_syncpts() has been unused since
> > commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA
> > fences")
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> > drivers/gpu/host1x/debug.c | 9 ---------
> > drivers/gpu/host1x/debug.h | 1 -
> > 2 files changed, 10 deletions(-)
> >
> > diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c
> > index a18cc8d8caf5..6433c00d5d7e 100644
> > --- a/drivers/gpu/host1x/debug.c
> > +++ b/drivers/gpu/host1x/debug.c
> > @@ -216,12 +216,3 @@ void host1x_debug_dump(struct host1x *host1x)
> > show_all(host1x, &o, true);
> > }
> > -
> > -void host1x_debug_dump_syncpts(struct host1x *host1x)
> > -{
> > - struct output o = {
> > - .fn = write_to_printk
> > - };
> > -
> > - show_syncpts(host1x, &o, false);
> > -}
> > diff --git a/drivers/gpu/host1x/debug.h b/drivers/gpu/host1x/debug.h
> > index 62bd8a091fa7..c43c61d876a9 100644
> > --- a/drivers/gpu/host1x/debug.h
> > +++ b/drivers/gpu/host1x/debug.h
> > @@ -41,6 +41,5 @@ extern unsigned int host1x_debug_trace_cmdbuf;
> > void host1x_debug_init(struct host1x *host1x);
> > void host1x_debug_deinit(struct host1x *host1x);
> > void host1x_debug_dump(struct host1x *host1x);
> > -void host1x_debug_dump_syncpts(struct host1x *host1x);
> > #endif
>
> Acked-by: Mikko Perttunen <mperttunen@nvidia.com>
Can this find it's way into drm please.
Thanks,
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts
2024-12-15 21:47 [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts linux
2024-12-17 7:24 ` Mikko Perttunen
@ 2025-02-28 16:46 ` Thierry Reding
2025-02-28 18:15 ` Dr. David Alan Gilbert
1 sibling, 1 reply; 5+ messages in thread
From: Thierry Reding @ 2025-02-28 16:46 UTC (permalink / raw)
To: linux; +Cc: mperttunen, linux-tegra, airlied, simona, dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
On Sun, Dec 15, 2024 at 09:47:50PM +0000, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> host1x_debug_dump_syncpts() has been unused since
> commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA
> fences")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> drivers/gpu/host1x/debug.c | 9 ---------
> drivers/gpu/host1x/debug.h | 1 -
> 2 files changed, 10 deletions(-)
Applied to drm-misc-next, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts
2025-02-28 16:46 ` Thierry Reding
@ 2025-02-28 18:15 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2025-02-28 18:15 UTC (permalink / raw)
To: Thierry Reding
Cc: mperttunen, linux-tegra, airlied, simona, dri-devel, linux-kernel
* Thierry Reding (thierry.reding@gmail.com) wrote:
> On Sun, Dec 15, 2024 at 09:47:50PM +0000, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > host1x_debug_dump_syncpts() has been unused since
> > commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA
> > fences")
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> > drivers/gpu/host1x/debug.c | 9 ---------
> > drivers/gpu/host1x/debug.h | 1 -
> > 2 files changed, 10 deletions(-)
>
> Applied to drm-misc-next, thanks.
Thanks
> Thierry
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-28 18:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-15 21:47 [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts linux
2024-12-17 7:24 ` Mikko Perttunen
2025-02-28 15:48 ` Dr. David Alan Gilbert
2025-02-28 16:46 ` Thierry Reding
2025-02-28 18:15 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox