From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C671C244EA1 for ; Wed, 12 Mar 2025 12:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741783549; cv=none; b=a5uA+c/TYr2682y6VokI1WeRAH0Tt+FswBI95a9yiH4s2N0BUVFacEKOWHwcIcPUepfyvs2I2IFQU/TcqLh8Qt+cD9QODFLc8t3Y+z6jFWwta5PZxlstyTXbvYeAtqcaNC+9Z/4bKdGIFZpwjW5am7cWSJhyMU2KVKFyoj5GDA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741783549; c=relaxed/simple; bh=w7qxWcK6Y+lr9flaT5izlqxkohZLAMbvmvIVsbTBCwo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ovsHC2MnKci86rqyD2HgFqPVCsyzqbCMiRp/pIrCSRIYci458U5DwrrM2ENxX9fimdVVAOwym+vPbYkothzWa47wedPONvJCbSsiwuziCr5Vq7A0QYnnYP940Ry4ZuvVvButxpPvC7TBPww11cfjhgvGV8byHcsdfqszkEppCwI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Ywe7fQuL; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Ywe7fQuL" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-438d9c391fcso44225e9.0 for ; Wed, 12 Mar 2025 05:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741783545; x=1742388345; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O7nXrf8enrrb8z3uABVuZMTlrSLNofRDk6iKufuqXac=; b=Ywe7fQuLhRoN2XSCceaZXzeIZbcdIXj1wOnXDBPxOkHZrgOblbnv3U04HQQh6srIsB caOSb8a7nwCJbLkVKUBuKCt4h9nKxHc/QpVBQSoxifq+iOEE1JN0YFFRaJVJBxbxnvXs I73XiZ3QkK7YgO9fc5tLiGYIu46Yop/8EgFDRBpPN+mbR/+DbSGP5yIzd+qv9KlU0C1/ ixqgSTtk2TavArOPSiMPB4vlrewijDM2wkx9MkfHZ/S825fdKGYwv/xYWwOS+c8B3ND3 UAoh5QzGh81Dh468uoDMfDNz7tJnvdZ5hhoaOZ8QSKxtKeJqWuwth6CILdNwpph2wXf3 nEtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741783545; x=1742388345; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O7nXrf8enrrb8z3uABVuZMTlrSLNofRDk6iKufuqXac=; b=vW7uZxiTXT1lmDTTnMYKTY8ZJf4nP5mCzE+axSd97JO0463W+a4cwTJBP770/P8fMa XtInEIjY0X6k1r/5jNKwKwnM2Je6x7pyraH/R+irElYVOA6piQe5wvOb+kU+WEa7pCxM 50J7oOXF/UpAIZUX33ipZo/S7NBOEv1n5lf+4n/KfvU4ROJi9/t3IsWgndBUKNp/uo1f bwLLpBf4yNqV/ZhRZbrMTd7tuFtXg+W9+lfaZXVXZK2UNWDsexI17TZmpLB92dAQkXE9 MVbuIkcNzeqPr8c6N7DtWLbNzkJAhLGjCjndncktVbe/glcoaFhnvkgz2VgE+fnbUCSH aO7g== X-Forwarded-Encrypted: i=1; AJvYcCUdsAgku7vVCeSSRooRWvcXwc1Fbz6RQvbmp5sbkSGl7U2lGFcew+O02amei+uqKzEW8gX+WfoFdeIiKA==@vger.kernel.org X-Gm-Message-State: AOJu0YyfGUSuB8TVsXpXBz5AgEK0kbgpXcPTYDr/0Cd7GFJm9q6HEpK0 KqvMGV3nC6/sKL5QsrbfyqnENxHQKXIX3LATKpXJI27ITQJ1RFdw8HlSgY/rFA== X-Gm-Gg: ASbGnct6uLm+LdteSKgkv9ibzMaQp6Zh6W1vz2792aqeFzbVGk1EBNh7qYTRDlKpOQb b3E4ReTY4KqkcKQPmQaZ2vLRbNJ5qcREuT8YYbJu+DbrpRxZRFL2m0oE9USWinrT0CXUDHIHFye z+TUImnIY9vYe3tT8sMMB5nHT2S230WJWNvRssTGVCFVxbvzhem8+l9U1jWQWBaKmLUPm5Wrh03 UcL0FFclaTsecR4D9CRQPKNcbgPDe8wJY1h2+mOYjnAy9tr8OQxHxELtKdAD9IM1Wp0fSgfyhcj eoE13MkmlmWpUKW13Jbr904RjXFLtMiRcQEMxCqfVJFkdc+4r2zDmDNR81z2YmqqDI7Ik+jMfrD j+GpsT9MOs94JJdE= X-Google-Smtp-Source: AGHT+IGl6ij5XGs/qN6P6iUkVVrm0h4AAzKswiqP0QsBVlB9onr8dRHcRoIgJqJfm8N1ML/DsO9qAQ== X-Received: by 2002:a05:600c:5801:b0:43b:bfe9:8b43 with SMTP id 5b1f17b1804b1-43d09ea3748mr1245205e9.4.1741783544916; Wed, 12 Mar 2025 05:45:44 -0700 (PDT) Received: from google.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d0a8c5d0fsm20697625e9.32.2025.03.12.05.45.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 05:45:44 -0700 (PDT) Date: Wed, 12 Mar 2025 12:45:39 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: Alim Akhtar , Alyssa Rosenzweig , Albert Ou , asahi@lists.linux.dev, Lu Baolu , David Woodhouse , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Jonathan Hunter , Joerg Roedel , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Marek Szyprowski , Hector Martin , Palmer Dabbelt , Paul Walmsley , Robin Murphy , Samuel Holland , Suravee Suthikulpanit , Sven Peter , Thierry Reding , Tomasz Jeznach , Krishna Reddy , Chen-Yu Tsai , Will Deacon , Bagas Sanjaya , Joerg Roedel , Pasha Tatashin , patches@lists.linux.dev, David Rientjes , Matthew Wilcox Subject: Re: [PATCH v3 15/23] iommu/pages: Move the __GFP_HIGHMEM checks into the common code Message-ID: References: <0-v3-e797f4dc6918+93057-iommu_pages_jgg@nvidia.com> <15-v3-e797f4dc6918+93057-iommu_pages_jgg@nvidia.com> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15-v3-e797f4dc6918+93057-iommu_pages_jgg@nvidia.com> On Tue, Feb 25, 2025 at 03:39:32PM -0400, Jason Gunthorpe wrote: > The entire allocator API is built around using the kernel virtual address, > it is illegal to pass GFP_HIGHMEM in as a GFP flag. Block it in the common > code. Remove the duplicated checks from drivers. > > Reviewed-by: Lu Baolu > Signed-off-by: Jason Gunthorpe Reviewed-by: Mostafa Saleh > --- > drivers/iommu/io-pgtable-arm.c | 2 -- > drivers/iommu/io-pgtable-dart.c | 1 - > drivers/iommu/iommu-pages.c | 4 ++++ > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c > index 62df2528d020b2..08d0f62abe8a09 100644 > --- a/drivers/iommu/io-pgtable-arm.c > +++ b/drivers/iommu/io-pgtable-arm.c > @@ -267,8 +267,6 @@ static void *__arm_lpae_alloc_pages(size_t size, gfp_t gfp, > dma_addr_t dma; > void *pages; > > - VM_BUG_ON((gfp & __GFP_HIGHMEM)); > - > if (cfg->alloc) > pages = cfg->alloc(cookie, size, gfp); > else > diff --git a/drivers/iommu/io-pgtable-dart.c b/drivers/iommu/io-pgtable-dart.c > index 7efcaea0bd5c86..ebf330e67bfa30 100644 > --- a/drivers/iommu/io-pgtable-dart.c > +++ b/drivers/iommu/io-pgtable-dart.c > @@ -111,7 +111,6 @@ static void *__dart_alloc_pages(size_t size, gfp_t gfp) > { > int order = get_order(size); > > - VM_BUG_ON((gfp & __GFP_HIGHMEM)); > return iommu_alloc_pages(gfp, order); > } > > diff --git a/drivers/iommu/iommu-pages.c b/drivers/iommu/iommu-pages.c > index 3077df642adb1f..a7eed09420a231 100644 > --- a/drivers/iommu/iommu-pages.c > +++ b/drivers/iommu/iommu-pages.c > @@ -37,6 +37,10 @@ void *iommu_alloc_pages_node(int nid, gfp_t gfp, unsigned int order) > const unsigned long pgcnt = 1UL << order; > struct folio *folio; > > + /* This uses page_address() on the memory. */ > + if (WARN_ON(gfp & __GFP_HIGHMEM)) > + return NULL; > + > /* > * __folio_alloc_node() does not handle NUMA_NO_NODE like > * alloc_pages_node() did. > -- > 2.43.0 >