[PATCH] drm/tegra: fix another missing include

[PATCH] drm/tegra: fix another missing include

[Christian König]

Since tegra now compile tests on other platforms the kernel test robot
started to complain that this here is not pulled in under all
conditions.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304050946.yGGTKkcr-lkp@intel.com/
---
 drivers/gpu/drm/tegra/fb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index bfebe2786d61..35b90fac5a47 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -8,6 +8,7 @@
  */
 
 #include <linux/console.h>
+#include <linux/vmalloc.h>
 
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
-- 
2.34.1

Re: [PATCH] drm/tegra: fix another missing include

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

On Wed, Apr 05, 2023 at 01:44:43PM +0200, Christian König wrote:
> Since tegra now compile tests on other platforms the kernel test robot
> started to complain that this here is not pulled in under all
> conditions.
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304050946.yGGTKkcr-lkp@intel.com/
> ---
>  drivers/gpu/drm/tegra/fb.c | 1 +
>  1 file changed, 1 insertion(+)

I had meant to bring this up in response to the other patch that you had
sent but then forgot. One of the sanity scripts I run complains that you
have different email addresses in the author and Signed-off-by: fields.
I already fixed that up for the original patch (I used the Signed-off-by
email for the author as well). Let me know if that's not how you want to
handle this.

May also be worth fixing up your setup so it doesn't generate these
conflicting entries.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] drm/tegra: fix another missing include

[Christian König]

Am 05.04.23 um 14:05 schrieb Thierry Reding:
> On Wed, Apr 05, 2023 at 01:44:43PM +0200, Christian König wrote:
>> Since tegra now compile tests on other platforms the kernel test robot
>> started to complain that this here is not pulled in under all
>> conditions.
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Link: https://lore.kernel.org/oe-kbuild-all/202304050946.yGGTKkcr-lkp@intel.com/
>> ---
>>   drivers/gpu/drm/tegra/fb.c | 1 +
>>   1 file changed, 1 insertion(+)
> I had meant to bring this up in response to the other patch that you had
> sent but then forgot. One of the sanity scripts I run complains that you
> have different email addresses in the author and Signed-off-by: fields.
> I already fixed that up for the original patch (I used the Signed-off-by
> email for the author as well). Let me know if that's not how you want to
> handle this.
>
> May also be worth fixing up your setup so it doesn't generate these
> conflicting entries.

Yeah, that's a well known issue.

The AMD mail servers are notoriously unreliable and mangle patches 
during sendout.

Because of this I've switched to using gmail for sending patches, but 
keep the author and Signed-of-by line with my AMD mail.

Christian.

>
> Thierry

Re: [PATCH] drm/tegra: fix another missing include

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 2079 bytes --]

On Wed, Apr 05, 2023 at 02:14:45PM +0200, Christian König wrote:
> Am 05.04.23 um 14:05 schrieb Thierry Reding:
> > On Wed, Apr 05, 2023 at 01:44:43PM +0200, Christian König wrote:
> > > Since tegra now compile tests on other platforms the kernel test robot
> > > started to complain that this here is not pulled in under all
> > > conditions.
> > > 
> > > Signed-off-by: Christian König <christian.koenig@amd.com>
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Link: https://lore.kernel.org/oe-kbuild-all/202304050946.yGGTKkcr-lkp@intel.com/
> > > ---
> > >   drivers/gpu/drm/tegra/fb.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > I had meant to bring this up in response to the other patch that you had
> > sent but then forgot. One of the sanity scripts I run complains that you
> > have different email addresses in the author and Signed-off-by: fields.
> > I already fixed that up for the original patch (I used the Signed-off-by
> > email for the author as well). Let me know if that's not how you want to
> > handle this.
> > 
> > May also be worth fixing up your setup so it doesn't generate these
> > conflicting entries.
> 
> Yeah, that's a well known issue.
> 
> The AMD mail servers are notoriously unreliable and mangle patches during
> sendout.
> 
> Because of this I've switched to using gmail for sending patches, but keep
> the author and Signed-of-by line with my AMD mail.

I've had to do the same for years as well. There's a trick you can do to
make git send-email add a From: header containing the author info of the
commit. git will then use this second From: header when applying patches
to keep the authorship information correct, even if you send from an
email address that doesn't match the author email.

I /think/ all you need to do is something like:

	$ git config sendemail.from "Christian König <ckoenig.leichtzumerken@gmail.com>"

Or adjust accordingly if you use different send-email accounts. git will
then notice that this doesn't match the authorship and fix it up.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]