From: Thierry Reding <thierry.reding@gmail.com>
To: Akhil R <akhilrajeev@nvidia.com>
Cc: christian.koenig@amd.com, digetx@gmail.com, jonathanh@nvidia.com,
ldewangan@nvidia.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
sumit.semwal@linaro.org, wsa@kernel.org
Subject: Re: [PATCH v4 2/2] i2c: tegra: Share same DMA channel for RX and TX
Date: Wed, 5 Apr 2023 14:26:38 +0200 [thread overview]
Message-ID: <ZC1o_sIuQIfHg9pi@orome> (raw)
In-Reply-To: <20230324115924.64218-3-akhilrajeev@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 547 bytes --]
On Fri, Mar 24, 2023 at 05:29:24PM +0530, Akhil R wrote:
> Allocate only one DMA channel for I2C and share it for both TX and RX
> instead of using two different DMA hardware channels with the same
> slave ID. Since I2C supports only half duplex, there is no impact on
> perf with this.
>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
> drivers/i2c/busses/i2c-tegra.c | 69 ++++++++++------------------------
> 1 file changed, 20 insertions(+), 49 deletions(-)
Looks good:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-04-05 12:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 11:59 [PATCH v4 0/2] Tegra I2C DMA and SMBus blockread updates Akhil R
2023-03-24 11:59 ` [PATCH v4 1/2] i2c: tegra: Fix PEC support for SMBUS block read Akhil R
2023-04-05 12:25 ` Thierry Reding
2023-04-05 16:11 ` Akhil R
2023-04-13 8:27 ` Thierry Reding
2023-04-13 9:40 ` Dmitry Osipenko
2023-03-24 11:59 ` [PATCH v4 2/2] i2c: tegra: Share same DMA channel for RX and TX Akhil R
2023-04-05 12:26 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC1o_sIuQIfHg9pi@orome \
--to=thierry.reding@gmail.com \
--cc=akhilrajeev@nvidia.com \
--cc=christian.koenig@amd.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox