From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Dmitry Osipenko <digetx@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-media@vger.kernel.org, linux-tegra@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 035/117] media: vde: Convert to platform remove callback returning void
Date: Tue, 4 Apr 2023 12:39:10 +0200 [thread overview]
Message-ID: <ZCv-ThTIKwSfa04P@orome> (raw)
In-Reply-To: <20230326143224.572654-38-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On Sun, Mar 26, 2023 at 04:31:02PM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/media/platform/nvidia/tegra-vde/vde.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-04-04 10:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 14:30 [PATCH 000/117] media: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 010/117] media: tegra_cec: " Uwe Kleine-König
2023-04-04 10:38 ` Thierry Reding
2023-03-26 14:31 ` [PATCH 035/117] media: vde: " Uwe Kleine-König
2023-04-04 10:39 ` Thierry Reding [this message]
2023-04-17 6:02 ` [PATCH 000/117] media: " Uwe Kleine-König
2023-04-17 6:19 ` Laurent Pinchart
2023-04-17 7:30 ` Uwe Kleine-König
2023-04-17 7:35 ` Laurent Pinchart
2023-04-17 7:57 ` Biju Das
2023-04-17 8:54 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCv-ThTIKwSfa04P@orome \
--to=thierry.reding@gmail.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox