From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC8DC71149 for ; Fri, 18 Aug 2023 13:51:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377379AbjHRNvP (ORCPT ); Fri, 18 Aug 2023 09:51:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377474AbjHRNvH (ORCPT ); Fri, 18 Aug 2023 09:51:07 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1318B44AA; Fri, 18 Aug 2023 06:50:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692366646; x=1723902646; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jK3rLN4QoYs7BnTEcvIivUoNPLOsFPYLk4t2kVLNIn0=; b=JRr6Sb1V8EjmZLIAsebTAbzIxXLqkX85dBdbk8K0NNBpR08i0wwZtSqB IGl9OUfK0xwzJ0q9cH60F9t/0ovpfpxa+kmT8KCD4KXEWJKwLn9kCId7j FKf4Vc/Ti+bq1qPC+PbgGr5V7SewqpQcnhnj2pp/nyXvVKrqR/sdD4B4f JfG8j9Cu5de6VG5ObNJCD2sCBXQ4sIzBUq1qY9E3FI/gUR3+5n0fRWkp3 aTS53LCqUqXkvsKw0Cnt+AumaJ5J2jC7erIHv9yOGYuhkS7EWYHwJS/TE NXo6+Yk+QbtPXtXaXoF0nwFx3ye0p50ir7wDe5OxWBprxkYoUoGb6tYLy g==; X-IronPort-AV: E=McAfee;i="6600,9927,10806"; a="459457309" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="459457309" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2023 06:50:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10806"; a="908888610" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="908888610" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 18 Aug 2023 06:50:41 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qWzs7-00AYtj-1Y; Fri, 18 Aug 2023 16:50:39 +0300 Date: Fri, 18 Aug 2023 16:50:39 +0300 From: Andy Shevchenko To: Kartik Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, sumitg@nvidia.com, arnd@arndb.de, pshete@nvidia.co, digetx@gmail.com, petlozup@nvidia.com, windhl@126.com, frank.li@vivo.com, robh@kernel.org, stefank@nvidia.com, pdeschrijver@nvidia.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] soc/tegra: fuse: Add function to register nvmem Message-ID: References: <20230818093028.7807-1-kkartik@nvidia.com> <20230818093028.7807-3-kkartik@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230818093028.7807-3-kkartik@nvidia.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Fri, Aug 18, 2023 at 03:00:24PM +0530, Kartik wrote: > Add helper function tegra_fuse_nvmem_register() to register > Tegra Fuse nvmem and use it in tegra_fuse_probe(). So, this can be > shared between device-tree and ACPI probe, which is to be introduced > later. ... > + fuse->nvmem = devm_nvmem_register(dev, &nvmem); > + if (IS_ERR(fuse->nvmem)) { > + err = PTR_ERR(fuse->nvmem); > + dev_err(dev, "failed to register NVMEM device: %d\n", > + err); > + return err; return dev_err_probe(); > + } > + > + return 0; > +} ... Seems it comes from the original code, so consider this as a suggestion for an additional improvement. -- With Best Regards, Andy Shevchenko