From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FA0113E7CD; Thu, 7 Mar 2024 21:44:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847843; cv=none; b=GkrMJh0W4BgctaOzz7AVqKZ29kjUPTce4mwdj23qi7Gtgi0Wf8zTaEkGpDsPclWnQxHEDKQO2SEYrwYUBvOLKb14JRjqaEDmUwfm1KIbqHNRzwfb5N3ALhjVcWcjLkiKLvxjVZCII1QKPv6UXc2iIVjqSRNN/Gg6TKlfltZN8AE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847843; c=relaxed/simple; bh=43Y8tPPUjOytn3k+9R6t1bkFGhFiAgq279o9cNEFG28=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LVlhtJpIQYvzYEFEiLZwi+4wLAalgEGRRBB1TWwRuSeodjEwapWnTk1aXre8izpCyCdd9LLQ5gjMpTHpO1dXXRUMw6DyH63Pak5kR7/PY6zzZP4JJSwWl9bhmVD/wOtdsWUZSW060wz7DxbUpmLlVIXhpg4OKZYo8NarJwws/UI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BD3HWBca; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BD3HWBca" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59403C433C7; Thu, 7 Mar 2024 21:43:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709847842; bh=43Y8tPPUjOytn3k+9R6t1bkFGhFiAgq279o9cNEFG28=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BD3HWBcaTEhFWmVQ9fcb4yZ5ZIcFpR9w6UwCqmKDGphQF7DB39yvDdZW9+gjF0ZTS DsWH87iS+8jHO65xN0z5zYohWG/mRxzpXe9VbFeimpkrU3bWSUCvWs70grrMlNEwLt TiJ4ebjjdAKjUVIIDkMAmBLRqlKaInuT9lf3cLYV5F5Yej/s3z0jy8l82WbWxo0F+u kTF29o9wK1pactXccrsfJOpfpW2c8/1s68hLjFvoICxKvPSf4JWeAYQXu8w1/yxijq 0mGAyNG2y48vVqRmPPE2wGjqjEVSxU5ubl2fEvD725m7YXDjcGo73gKcTwXXXTWbK0 khMLpaPck1T+w== Date: Thu, 7 Mar 2024 22:43:52 +0100 From: Niklas Cassel To: Manivannan Sadhasivam Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com Subject: Re: [PATCH v9 09/10] PCI: qcom-ep: Use the generic dw_pcie_ep_linkdown() API to handle LINK_DOWN event Message-ID: References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-9-29d433d99cda@linaro.org> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304-pci-dbi-rework-v9-9-29d433d99cda@linaro.org> On Mon, Mar 04, 2024 at 02:52:21PM +0530, Manivannan Sadhasivam wrote: > Now that the API is available, let's make use of it. It also handles the > reinitialization of DWC non-sticky registers in addition to sending the > notification to EPF drivers. > > Signed-off-by: Manivannan Sadhasivam > --- > drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c > index 2fb8c15e7a91..4e45bc4bca45 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c > +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c > @@ -640,7 +640,7 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data) > if (FIELD_GET(PARF_INT_ALL_LINK_DOWN, status)) { > dev_dbg(dev, "Received Linkdown event\n"); > pcie_ep->link_status = QCOM_PCIE_EP_LINK_DOWN; > - pci_epc_linkdown(pci->ep.epc); > + dw_pcie_ep_linkdown(&pci->ep); > } else if (FIELD_GET(PARF_INT_ALL_BME, status)) { > dev_dbg(dev, "Received BME event. Link is enabled!\n"); > pcie_ep->link_status = QCOM_PCIE_EP_LINK_ENABLED; > > -- > 2.25.1 > Reviewed-by: Niklas Cassel