Re: [PATCH v1 1/1] PCI: dwc: Remove unused of_gpio.h

Manivannan Sadhasivam
2024-03-08T17:10:42Z

On Fri, Mar 08, 2024 at 02:09:25PM +0200, Andy Shevchenko wrote:
> On Fri, Mar 08, 2024 at 03:25:47PM +0530, Manivannan Sadhasivam wrote:
> > On Thu, Mar 07, 2024 at 02:28:40PM +0200, Andy Shevchenko wrote:
> > > of_gpio.h is deprecated and subject to remove.
> > > The driver doesn't use it, simply remove the unused header.
>
> > What about the rest?
> >
> > drivers/pci/controller/dwc/pcie-kirin.c
> > drivers/pci/controller/dwc/pci-imx6.c
>
> Have you chance to look at them?
>

Ok. I failed to spot the usage of of_get_named_gpio() in both drivers. But you
already submitted a patch to convert kirin last year [1], and that didn't get
any love from the maintainers. Could you please respin? Perhaps convert imx6
also?

[1] https://lore.kernel.org/all/20230213180735.42117-1-andriy.shevchenko@linux.intel.com/

> > There is also one non-dwc driver:
> >
> > drivers/pci/controller/pci-aardvark.c
>
> Keyword: non-dwc.
> This patch is for DesignWare controllers that confirmed not using the header.
>
> > It is better to remove it from all PCI drivers in a single patch.
>
> I disagree on this. These are different drivers and even inside DesignWare not
> all of them can be converted with a simple change like this one.
>

Since this is just a header removal I thought you can just send a single patch
for these drivers since there is nothing special that warrants a separate patch
for aardvark (both are inside the drivers/pci/ hierarchy).

But anyway, I wouldn't press for it.

> That said, please consider applying this one as is.
>

I can give my R-o-b tag, but Lorenzo or Krzysztof will apply this.

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

- Mani

--
மணிவண்ணன் சதாசிவம்