From: Jon Hunter <jonathanh@nvidia.com>
To: webgeek1234@gmail.com, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: tegra: Remove otg id gpio from Jetson TX2 NX
Date: Wed, 17 Sep 2025 14:36:34 +0100 [thread overview]
Message-ID: <a3833c6b-5574-4aaf-86cc-66c10801ff3a@nvidia.com> (raw)
In-Reply-To: <20250513-tx2nx-role-switch-v1-1-d92ea1870ea5@gmail.com>
On 13/05/2025 22:10, Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@gmail.com>
>
> The p3509 carrier board does not connect the id gpio. Prior to this, the
> gpio role switch driver could not detect the mode of the otg port.
>
We should add a fixes tag here.
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra186-p3509-0000+p3636-0001.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra186-p3509-0000+p3636-0001.dts b/arch/arm64/boot/dts/nvidia/tegra186-p3509-0000+p3636-0001.dts
> index 26f71651933d1d8ef32bbd1645cac1820bd2e104..81f204e456409df355bbcb691ef99b0d0c9d504e 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra186-p3509-0000+p3636-0001.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra186-p3509-0000+p3636-0001.dts
> @@ -669,7 +669,6 @@ connector {
> vbus-gpios = <&gpio
> TEGRA186_MAIN_GPIO(L, 4)
> GPIO_ACTIVE_LOW>;
> - id-gpios = <&pmic 0 GPIO_ACTIVE_HIGH>;
> };
> };
>
Otherwise looks good to me.
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2025-09-17 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 21:10 [PATCH] arm64: tegra: Remove otg id gpio from Jetson TX2 NX Aaron Kling via B4 Relay
2025-05-28 17:42 ` Aaron Kling
2025-06-30 19:27 ` Aaron Kling
2025-07-14 5:35 ` Aaron Kling
2025-07-31 21:36 ` Aaron Kling
2025-08-01 9:43 ` Thierry Reding
2025-08-18 18:56 ` Aaron Kling
2025-09-14 14:24 ` Aaron Kling
2025-09-17 13:36 ` Jon Hunter [this message]
2025-10-20 19:19 ` Aaron Kling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3833c6b-5574-4aaf-86cc-66c10801ff3a@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox