From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH V2 09/21] clk: tegra: dfll: add protection for find_vdd_map APIs Date: Thu, 13 Dec 2018 12:46:11 +0000 Message-ID: References: <20181213093438.29621-1-josephl@nvidia.com> <20181213093438.29621-10-josephl@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181213093438.29621-10-josephl@nvidia.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Joseph Lo , Thierry Reding , Peter De Schrijver Cc: linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-tegra@vger.kernel.org On 13/12/2018 09:34, Joseph Lo wrote: > The DFLL hardware supports both I2C and PWM based regulator. SW driver > only touches I2C regulator when generating LUT. And shouldn't touch it > anymore once the DFLL is enabled. I am not sure that the last two sentences are above are relevant and confused me a little at first. I would be tempted to drop them. > This patch adds the protection for the APIs that only work with I2C mode > to avoid they could be called accidentally. > > Signed-off-by: Joseph Lo Furthermore, I would be tempted to squash this into patch #7. I am not sure another patch is warranted here. Cheers Jon -- nvpublic