Re: [PATCH v2 2/2] dt-bindings: dma: nvidia,tegra20-apbdma: convert text based binding to json schema

[Charan Pedumuru <charan.pedumuru@gmail.com>]

On 06-05-2025 13:00, Krzysztof Kozlowski wrote:
> On 06/05/2025 09:07, Charan Pedumuru wrote:
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
> 
> Why is this a irq.h now?
> 
>> +    #include <dt-bindings/reset/tegra186-reset.h>
>> +    dma-controller@6000a000 {
>> +        compatible = "nvidia,tegra30-apbdma", "nvidia,tegra20-apbdma";
>> +        reg = <0x6000a000 0x1200>;
>> +        interrupts = <0 136 0x04>,
>> +                     <0 137 0x04>,
>> +                     <0 138 0x04>,
>> +                     <0 139 0x04>,
>> +                     <0 140 0x04>,
>> +                     <0 141 0x04>,
>> +                     <0 142 0x04>,
>> +                     <0 143 0x04>,
>> +                     <0 144 0x04>,
>> +                     <0 145 0x04>,
>> +                     <0 146 0x04>,
>> +                     <0 147 0x04>,
>> +                     <0 148 0x04>,
>> +                     <0 149 0x04>,
>> +                     <0 150 0x04>,
>> +                     <0 151 0x04>;
> 
> 
> Again, quoting:
> 
> You included this...
> ... so use it.
> 
> Otherwise what would be the point of including the header?


Yes, I understood it now, will remove the header.


> 
>> +        clocks = <&tegra_car 34>;
>> +        resets = <&tegra_car 34>;
>> +        reset-names = "dma";
>> +        #dma-cells = <1>;
>> +    };
>> +...
>>
> 
> 
> Best regards,
> Krzysztof

-- 
Best Regards,
Charan.