Re: [PATCH v1 07/16] iommufd/viommu: Add driver-allocated vDEVICE support

Nicolin Chen
2025-04-21T15:35:46Z

On Mon, Apr 21, 2025 at 08:00:37AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@nvidia.com>
> > Sent: Friday, April 11, 2025 2:38 PM
> >
> > @@ -128,6 +142,9 @@ struct iommufd_viommu_ops {
> > const struct iommu_user_data *user_data);
> > int (*cache_invalidate)(struct iommufd_viommu *viommu,
> > struct iommu_user_data_array *array);
> > + struct iommufd_vdevice *(*vdevice_alloc)(struct iommufd_viommu
> > *viommu,
> > + struct device *dev, u64 id);
>
> s/id/virt_id/ would be clearer.

OK.

@@ -143,7 +143,8 @@ struct iommufd_viommu_ops {
int (*cache_invalidate)(struct iommufd_viommu *viommu,
struct iommu_user_data_array *array);
struct iommufd_vdevice *(*vdevice_alloc)(struct iommufd_viommu *viommu,
- struct device *dev, u64 id);
+ struct device *dev,
+ u64 virt_id);
void (*vdevice_destroy)(struct iommufd_vdevice *vdev);
};

Thanks
Nicolin