From: Nicolin Chen <nicolinc@nvidia.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Alexandre Ghiti <alex@ghiti.fr>,
Alim Akhtar <alim.akhtar@samsung.com>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Albert Ou <aou@eecs.berkeley.edu>, <asahi@lists.linux.dev>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"David Woodhouse" <dwmw2@infradead.org>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Heiko Stuebner <heiko@sntech.de>, <iommu@lists.linux.dev>,
Janne Grunau <j@jannau.net>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Joerg Roedel <joro@8bytes.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-riscv@lists.infradead.org>,
<linux-rockchip@lists.infradead.org>,
<linux-s390@vger.kernel.org>, <linux-samsung-soc@vger.kernel.org>,
<linux-sunxi@lists.linux.dev>, <linux-tegra@vger.kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
Neal Gompa <neal@gompa.dev>, Orson Zhai <orsonzhai@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Rob Clark <robin.clark@oss.qualcomm.com>,
"Robin Murphy" <robin.murphy@arm.com>,
Samuel Holland <samuel@sholland.org>,
"Sven Peter" <sven@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
"Krishna Reddy" <vdumpa@nvidia.com>,
<virtualization@lists.linux.dev>, Chen-Yu Tsai <wens@csie.org>,
Will Deacon <will@kernel.org>, Yong Wu <yong.wu@mediatek.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Kevin Tian <kevin.tian@intel.com>, <patches@lists.linux.dev>,
Niklas Schnelle <schnelle@linux.ibm.com>,
"Sven Peter" <sven@svenpeter.dev>,
Tomasz Jeznach <tjeznach@rivosinc.com>
Subject: Re: [PATCH v2 0/7] Remove ops.pgsize_bitmap
Date: Mon, 9 Jun 2025 15:45:20 -0700 [thread overview]
Message-ID: <aEdkADqw6WGIPAmH@nvidia.com> (raw)
In-Reply-To: <0-v2-68a2e1ba507c+1fb-iommu_rm_ops_pgsize_jgg@nvidia.com>
On Mon, Jun 09, 2025 at 05:41:24PM -0300, Jason Gunthorpe wrote:
> Now that all drivers are using domain_alloc_paging() and dev is never
> NULL, we can have all drivers correctly set domain.pgsize_bitmap during
> their allocation function.
>
> There are a few oddities that have accumulated here over past changes:
>
> - Some drivers always set domain.pgsize_bitmap during their
> domain_alloc_paging() call but still provide a value in ops. This is dead
> code, delete it.
>
> - Some drivers calculate a system global pgsize_bitmap in the ops, but
> it is now trivial to use the per-instance value instead. In several
> cases this is dead code, delete it. This also allows
> constifying the ops in these drivers as a hardening measure
>
> - Some drivers have a fixed pgsize_bitmap, put it next to setting up the
> geometry in their domain_alloc_paging() functions.
>
> - Finally a few drivers still use ops because they have a delayed
> finalize operation. Set the constant pgsize_bitmap in the
> domain_alloc_paging().
>
> Then remove ops.pgsize_bitmap.
>
> This is based on iommu next, and must go after the virtio
> domain_alloc_paging() conversion.
>
> v2:
> - Rebase on v6.16-rc1
Sanity tests with SMMUv3 look good.
Tested-by: Nicolin Chen <nicolinc@nvidia.com>
next prev parent reply other threads:[~2025-06-09 22:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 20:41 [PATCH v2 0/7] Remove ops.pgsize_bitmap Jason Gunthorpe
2025-06-09 20:41 ` [PATCH v2 1/7] qiommu/arm-smmu-v3: Remove iommu_ops pgsize_bitmap Jason Gunthorpe
2025-06-09 22:15 ` Nicolin Chen
2025-06-09 23:11 ` Jason Gunthorpe
2025-06-09 20:41 ` [PATCH v2 2/7] iommu/arm-smmu: " Jason Gunthorpe
2025-06-09 20:41 ` [PATCH v2 3/7] iommu: Remove ops.pgsize_bitmap from drivers that don't use it Jason Gunthorpe
2025-06-09 20:41 ` [PATCH v2 4/7] iommu: Remove iommu_ops pgsize_bitmap from simple drivers Jason Gunthorpe
2025-06-10 3:47 ` Chen-Yu Tsai
2025-06-10 9:11 ` Thierry Reding
2025-06-11 9:40 ` AngeloGioacchino Del Regno
2025-06-11 9:46 ` Marek Szyprowski
2025-06-09 20:41 ` [PATCH v2 5/7] iommu/mtk: Remove iommu_ops pgsize_bitmap Jason Gunthorpe
2025-06-11 9:40 ` AngeloGioacchino Del Regno
2025-06-09 20:41 ` [PATCH v2 6/7] iommu/qcom: " Jason Gunthorpe
2025-06-09 20:41 ` [PATCH v2 7/7] iommu: Remove ops->pgsize_bitmap Jason Gunthorpe
2025-06-27 8:28 ` Joerg Roedel
2025-06-27 12:59 ` Jason Gunthorpe
2025-06-09 22:45 ` Nicolin Chen [this message]
2025-06-27 6:56 ` [PATCH v2 0/7] Remove ops.pgsize_bitmap Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEdkADqw6WGIPAmH@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=alex@ghiti.fr \
--cc=alim.akhtar@samsung.com \
--cc=alyssa@rosenzweig.io \
--cc=angelogioacchino.delregno@collabora.com \
--cc=aou@eecs.berkeley.edu \
--cc=asahi@lists.linux.dev \
--cc=baolin.wang@linux.alibaba.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=j@jannau.net \
--cc=jean-philippe@linaro.org \
--cc=jernej.skrabec@gmail.com \
--cc=jgg@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matthias.bgg@gmail.com \
--cc=mjrosato@linux.ibm.com \
--cc=neal@gompa.dev \
--cc=orsonzhai@gmail.com \
--cc=palmer@dabbelt.com \
--cc=patches@lists.linux.dev \
--cc=paul.walmsley@sifive.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
--cc=samuel@sholland.org \
--cc=schnelle@linux.ibm.com \
--cc=sven@kernel.org \
--cc=sven@svenpeter.dev \
--cc=thierry.reding@gmail.com \
--cc=tjeznach@rivosinc.com \
--cc=vdumpa@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=wens@csie.org \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).