From: Herbert Xu <herbert@gondor.apana.org.au>
To: Qianfeng Rong <rongqianfeng@vivo.com>
Cc: "Ashish Kalra" <ashish.kalra@amd.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"John Allen" <john.allen@amd.com>,
"David S. Miller" <davem@davemloft.net>,
"Akhil R" <akhilrajeev@nvidia.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Colin Ian King" <colin.i.king@gmail.com>,
"open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - SE..."
<linux-crypto@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:TEGRA ARCHITECTURE SUPPORT"
<linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 0/3] crypto: Use int type to store negative error codes
Date: Sat, 13 Sep 2025 12:27:25 +0800 [thread overview]
Message-ID: <aMTyraqo3GukxpnO@gondor.apana.org.au> (raw)
In-Reply-To: <20250903132539.416439-1-rongqianfeng@vivo.com>
On Wed, Sep 03, 2025 at 09:25:34PM +0800, Qianfeng Rong wrote:
> The 'ret' variable usually is used to store returns from some functions,
> which return either zero on success or negative error codes on failure.
>
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but can be confusing. Additionally, assigning negative error
> codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
> flag is enabled.
>
> Change 'ret' from u32/unsigned int to int type. No effect on runtime.
>
> Qianfeng Rong (3):
> crypto: ccp - Use int type to store negative error codes
> crypto: hisilicon/sec - Use int type to store negative error codes
> crypto: tegra - Use int type to store negative error codes
>
> drivers/crypto/ccp/sev-dev.c | 3 ++-
> drivers/crypto/hisilicon/sec/sec_drv.c | 3 ++-
> drivers/crypto/tegra/tegra-se-hash.c | 3 ++-
> 3 files changed, 6 insertions(+), 3 deletions(-)
>
> --
> 2.34.1
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2025-09-13 4:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 13:25 [PATCH 0/3] crypto: Use int type to store negative error codes Qianfeng Rong
2025-09-03 13:25 ` [PATCH 3/3] crypto: tegra - " Qianfeng Rong
2025-09-13 4:27 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMTyraqo3GukxpnO@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akhilrajeev@nvidia.com \
--cc=ashish.kalra@amd.com \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=john.allen@amd.com \
--cc=jonathanh@nvidia.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rongqianfeng@vivo.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.lendacky@amd.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox