From: Niklas Cassel <cassel@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Vidya Sagar" <vidyas@nvidia.com>,
"Shin'ichiro Kawasaki" <shinichiro.kawasaki@wdc.com>,
"Nagarjuna Kristam" <nkristam@nvidia.com>,
linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra194: Fix duplicate pll disable
Date: Mon, 22 Sep 2025 08:51:03 +0200 [thread overview]
Message-ID: <aNDx15Per942jtCl@ryzen> (raw)
In-Reply-To: <175838274651.17577.4183778050259320426.b4-ty@kernel.org>
On Sat, Sep 20, 2025 at 09:10:19PM +0530, Manivannan Sadhasivam wrote:
>
> On Thu, 11 Sep 2025 11:30:22 +0200, Niklas Cassel wrote:
> > During PERST# assertion tegra_pcie_bpmp_set_pll_state() is currently
> > called twice.
> >
> > pex_ep_event_pex_rst_assert() should do the opposite of
> > pex_ep_event_pex_rst_deassert(), so it is obvious that the duplicate
> > tegra_pcie_bpmp_set_pll_state() is a mistake, and that the duplicate
> > tegra_pcie_bpmp_set_pll_state() call should instead be a call to
> > tegra_pcie_bpmp_set_ctrl_state().
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] PCI: tegra194: Fix duplicate pll disable
> commit: 3fab9e8102f7f7c5099d69f8e00f478e8795f528
>
> Note: I've added the Fixes tag a54e19073718, which added the duplicate
> tegra_pcie_bpmp_set_pll_state() call.
Thank you Mani,
However, I don't see 3fab9e8102f7f7c5099d69f8e00f478e8795f528 on any branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/
Did you perhaps forget to push?
Kind regards,
Niklas
next prev parent reply other threads:[~2025-09-22 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 9:30 [PATCH] PCI: tegra194: Fix duplicate pll disable Niklas Cassel
2025-09-20 15:40 ` Manivannan Sadhasivam
2025-09-22 6:51 ` Niklas Cassel [this message]
2025-09-22 8:11 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNDx15Per942jtCl@ryzen \
--to=cassel@kernel.org \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=nkristam@nvidia.com \
--cc=robh@kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox