Re: [PATCH v5 1/4] memory: tegra: Group mc-err related registers

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

On Fri, Dec 19, 2025 at 11:43:51AM +0000, Ketan Patil wrote:
[...]
> diff --git a/include/soc/tegra/mc.h b/include/soc/tegra/mc.h
[...]
> @@ -168,6 +168,23 @@ struct tegra_mc_ops {
>  	int (*probe_device)(struct tegra_mc *mc, struct device *dev);
>  };
>  
> +struct tegra_mc_regs {
> +	unsigned int mc_cfg_channel_enable;
> +	unsigned int mc_err_status;
> +	unsigned int mc_err_add;
> +	unsigned int mc_err_add_hi;
> +	unsigned int mc_err_vpr_status;
> +	unsigned int mc_err_vpr_add;
> +	unsigned int mc_err_sec_status;
> +	unsigned int mc_err_sec_add;
> +	unsigned int mc_err_mts_status;
> +	unsigned int mc_err_mts_add;
> +	unsigned int mc_err_gen_co_status;
> +	unsigned int mc_err_gen_co_add;
> +	unsigned int mc_err_route_status;
> +	unsigned int mc_err_route_add;

There's really no need for the mc_ prefix here since the structure is
already called tegra_mc_regs.

> +};
> +
>  struct tegra_mc_soc {
>  	const struct tegra_mc_client *clients;
>  	unsigned int num_clients;
> @@ -196,6 +213,7 @@ struct tegra_mc_soc {
>  
>  	const struct tegra_mc_icc_ops *icc_ops;
>  	const struct tegra_mc_ops *ops;
> +	const struct tegra_mc_regs *mc_regs;
>  };

Similarly, there's only one "regs" structure, and it's embedded inside a
structure that is all about the MC, so the mc_ prefix can be omitted.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]