* [PATCH] staging: nvec: fix block comment style
@ 2026-03-02 1:40 Afkari Zergaw
2026-03-09 16:28 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Afkari Zergaw @ 2026-03-02 1:40 UTC (permalink / raw)
To: marvin24, gregkh; +Cc: linux-staging, linux-tegra, linux-kernel, Afkari Zergaw
Convert a block comment in nvec.c to follow the kernel block
comment style where subsequent lines start with '*'.
Signed-off-by: Afkari Zergaw <afkarizergaw12@gmail.com>
---
drivers/staging/nvec/nvec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index e9af66a08448..0e655f79ea4a 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -660,7 +660,8 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
to_send = nvec->tx->data[0];
nvec->tx->pos = 1;
/* delay ACK due to AP20 HW Bug
- do not replace by usleep_range */
+ * do not replace by usleep_range
+ */
udelay(33);
} else if (status == (I2C_SL_IRQ)) {
nvec->rx->data[1] = received;
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] staging: nvec: fix block comment style
@ 2026-03-04 5:47 Avon-Hermit
2026-03-06 5:01 ` Avon Hermit
0 siblings, 1 reply; 4+ messages in thread
From: Avon-Hermit @ 2026-03-04 5:47 UTC (permalink / raw)
To: Marc Dietrich
Cc: Greg Kroah-Hartman, ac100, linux-tegra, linux-staging,
linux-kernel, Avon-Hermit
Convert a block comment describing the AP20 hardware bug workaround
to the preferred kernel block comment format.
This change only adjusts the comment style and does not modify the
behavior of the driver.
Signed-off-by: Avon-Hermit <avon.hermit@gmail.com>
---
drivers/staging/nvec/nvec.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index e9af66a08448..736f11942174 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -659,8 +659,9 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
nvec_tx_set(nvec);
to_send = nvec->tx->data[0];
nvec->tx->pos = 1;
- /* delay ACK due to AP20 HW Bug
- do not replace by usleep_range */
+ /*
+ * Delay ACK due to AP20 HW Bug; do not replace by usleep_range.
+ */
udelay(33);
} else if (status == (I2C_SL_IRQ)) {
nvec->rx->data[1] = received;
--
2.47.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: nvec: fix block comment style
2026-03-04 5:47 [PATCH] staging: nvec: fix block comment style Avon-Hermit
@ 2026-03-06 5:01 ` Avon Hermit
0 siblings, 0 replies; 4+ messages in thread
From: Avon Hermit @ 2026-03-06 5:01 UTC (permalink / raw)
To: Marc Dietrich
Cc: Greg Kroah-Hartman, ac100, linux-tegra, linux-staging,
linux-kernel
Hi,
Sorry, I didn't notice the earlier patch.
Please ignore this one.
Thanks,
Avon
On Wed, Mar 04, 2026 at 01:47:20PM +0800, Avon-Hermit wrote:
> Convert a block comment describing the AP20 hardware bug workaround
> to the preferred kernel block comment format.
>
> This change only adjusts the comment style and does not modify the
> behavior of the driver.
>
> Signed-off-by: Avon-Hermit <avon.hermit@gmail.com>
> ---
> drivers/staging/nvec/nvec.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index e9af66a08448..736f11942174 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -659,8 +659,9 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> nvec_tx_set(nvec);
> to_send = nvec->tx->data[0];
> nvec->tx->pos = 1;
> - /* delay ACK due to AP20 HW Bug
> - do not replace by usleep_range */
> + /*
> + * Delay ACK due to AP20 HW Bug; do not replace by usleep_range.
> + */
> udelay(33);
> } else if (status == (I2C_SL_IRQ)) {
> nvec->rx->data[1] = received;
> --
> 2.47.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: nvec: fix block comment style
2026-03-02 1:40 Afkari Zergaw
@ 2026-03-09 16:28 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2026-03-09 16:28 UTC (permalink / raw)
To: Afkari Zergaw; +Cc: marvin24, linux-staging, linux-tegra, linux-kernel
On Mon, Mar 02, 2026 at 01:40:15AM +0000, Afkari Zergaw wrote:
> Convert a block comment in nvec.c to follow the kernel block
> comment style where subsequent lines start with '*'.
>
> Signed-off-by: Afkari Zergaw <afkarizergaw12@gmail.com>
> ---
> drivers/staging/nvec/nvec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index e9af66a08448..0e655f79ea4a 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -660,7 +660,8 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> to_send = nvec->tx->data[0];
> nvec->tx->pos = 1;
> /* delay ACK due to AP20 HW Bug
> - do not replace by usleep_range */
> + * do not replace by usleep_range
> + */
> udelay(33);
> } else if (status == (I2C_SL_IRQ)) {
> nvec->rx->data[1] = received;
> --
> 2.43.0
>
>
Does not apply to my tree :(
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-09 16:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-04 5:47 [PATCH] staging: nvec: fix block comment style Avon-Hermit
2026-03-06 5:01 ` Avon Hermit
-- strict thread matches above, loose matches on Subject: below --
2026-03-02 1:40 Afkari Zergaw
2026-03-09 16:28 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox