From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Benjamin Bara <bbara93@gmail.com>
Cc: benjamin.bara@skidata.com, jonathanh@nvidia.com, lee@kernel.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, rafael.j.wysocki@intel.com,
richard.leitner@linux.dev, treding@nvidia.com, wsa@kernel.org
Subject: Re: [PATCH v3 4/4] mfd: tps6586x: register restart handler
Date: Mon, 3 Apr 2023 18:44:16 +0300 [thread overview]
Message-ID: <ab4d8e1e-d378-85d2-34aa-404ff178c49f@collabora.com> (raw)
In-Reply-To: <20230403065013.520339-1-bbara93@gmail.com>
On 4/3/23 09:50, Benjamin Bara wrote:
> Thanks for the feedback!
>
> The DS states: "When the reboot request state is set an internal timer TWAIT
> (10ms typ) is started. The reboot request ends when t > TWAIT."
>
> Therefore, my intention was to wait a little bit before starting the next
> handler in the chain. I can do some tests without the mdelay, but otherwise
> will reduce it to 15ms in the next patch. What do you think about it?
Sounds good. Please add a clarifying comment for the delay to the code.
--
Best regards,
Dmitry
prev parent reply other threads:[~2023-04-03 15:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 13:57 [PATCH v3 0/4] mfd: tps6586x: register restart handler Benjamin Bara
2023-03-27 13:57 ` [PATCH v3 1/4] kernel/reboot: emergency_restart: set correct system_state Benjamin Bara
2023-03-27 13:57 ` [PATCH v3 2/4] i2c: core: run atomic i2c xfer when !preemptible Benjamin Bara
2023-03-27 14:54 ` Wolfram Sang
2023-03-27 16:23 ` Benjamin Bara
2023-03-29 19:50 ` Wolfram Sang
2023-04-02 10:04 ` Benjamin Bara
2023-04-04 8:22 ` Peter Zijlstra
2023-04-04 14:06 ` Benjamin Bara
2023-03-27 13:57 ` [PATCH v3 3/4] mfd: tps6586x: use devm-based power off handler Benjamin Bara
2023-04-02 22:28 ` Dmitry Osipenko
2023-03-27 13:57 ` [PATCH v3 4/4] mfd: tps6586x: register restart handler Benjamin Bara
2023-04-02 22:30 ` Dmitry Osipenko
2023-04-03 6:50 ` Benjamin Bara
2023-04-03 15:44 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab4d8e1e-d378-85d2-34aa-404ff178c49f@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=bbara93@gmail.com \
--cc=benjamin.bara@skidata.com \
--cc=jonathanh@nvidia.com \
--cc=lee@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=richard.leitner@linux.dev \
--cc=treding@nvidia.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox