From: Dipen Patel <dipenp@nvidia.com>
To: Pan Chuang <panchuang@vivo.com>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
"open list:HTE SUBSYSTEM" <timestamp@lists.linux.dev>,
"open list:TEGRA ARCHITECTURE SUPPORT"
<linux-tegra@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Subject: Re: [PATCH v2] hte: tegra194: Remove redundant dev_err()
Date: Mon, 31 Aug 2026 21:49:10 -0700 [thread overview]
Message-ID: <ad6a2528-c2ca-452e-8648-27325ca3adf0@nvidia.com> (raw)
In-Reply-To: <20260716073416.530829-1-panchuang@vivo.com>
On 7/16/26 12:34 AM, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
> drivers/hte/hte-tegra194.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c
> index 4a7702b32b24..e29fb105ca2d 100644
> --- a/drivers/hte/hte-tegra194.c
> +++ b/drivers/hte/hte-tegra194.c
> @@ -856,10 +856,8 @@ static int tegra_hte_probe(struct platform_device *pdev)
> hte_dev->hte_irq = ret;
> ret = devm_request_irq(dev, hte_dev->hte_irq, tegra_hte_isr, 0,
> dev_name(dev), hte_dev);
> - if (ret < 0) {
> - dev_err(dev, "request irq failed.\n");
> + if (ret < 0)
> return ret;
> - }
>
> gc->nlines = nlines;
> gc->ops = &g_ops;
Acked-by: Dipen Patel <dipenp@nvidia.com>
prev parent reply other threads:[~2026-09-01 4:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 7:34 [PATCH v2] hte: tegra194: Remove redundant dev_err() Pan Chuang
2026-09-01 4:49 ` Dipen Patel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad6a2528-c2ca-452e-8648-27325ca3adf0@nvidia.com \
--to=dipenp@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=panchuang@vivo.com \
--cc=thierry.reding@kernel.org \
--cc=timestamp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox