From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Svyatoslav Ryhel <clamor95@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1] memory: tegra30-emc: Print additional memory info
Date: Mon, 20 Dec 2021 18:27:20 +0300 [thread overview]
Message-ID: <af428524-c630-64b9-5d67-22714ebe8d15@gmail.com> (raw)
In-Reply-To: <20211217234711.8353-1-digetx@gmail.com>
18.12.2021 02:47, Dmitry Osipenko пишет:
> +static int emc_read_lpddr_mode_register(struct tegra_emc *emc,
> + unsigned int emem_dev,
> + unsigned int register_addr,
> + unsigned int *register_data)
> +{
> + u32 memory_dev = emem_dev + 1;
I just noticed in the datasheet that memory_dev needs to be inverted,
otherwise we read dev0 instead of dev1 and vice versa. This also needs
to be corrected in the T20 EMC driver. It's not really a problem since
both memory chips usually are equal, nevertheless I'll fix it in v2
after we will decide on whether this code needs to be shared or not.
prev parent reply other threads:[~2021-12-20 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 23:47 [PATCH v1] memory: tegra30-emc: Print additional memory info Dmitry Osipenko
2021-12-20 11:03 ` Krzysztof Kozlowski
2021-12-20 13:44 ` Dmitry Osipenko
2021-12-21 8:14 ` Krzysztof Kozlowski
2021-12-21 15:34 ` Dmitry Osipenko
2021-12-20 15:27 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af428524-c630-64b9-5d67-22714ebe8d15@gmail.com \
--to=digetx@gmail.com \
--cc=clamor95@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox