From: Jon Hunter <jonathanh@nvidia.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/5] PM / Domains: Export symbol for genpd_dev_pm_attach_by_name
Date: Wed, 26 Sep 2018 16:02:07 +0100 [thread overview]
Message-ID: <afd04dd4-4199-9bb8-1b21-11444bb1773a@nvidia.com> (raw)
In-Reply-To: <CAPDyKFrtw1aYg5QbgRi_jp-xd0VLNeRYhb4HvX4P3AfGjgO0VA@mail.gmail.com>
On 26/09/18 15:09, Ulf Hansson wrote:
> On 26 September 2018 at 14:27, Jon Hunter <jonathanh@nvidia.com> wrote:
>> Export the symbol for genpd_dev_pm_attach_by_name() so that drivers
>> built as modules can call this function.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> drivers/base/power/domain.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
>> index 4b5714199490..b2bbe0d848d2 100644
>> --- a/drivers/base/power/domain.c
>> +++ b/drivers/base/power/domain.c
>> @@ -2397,6 +2397,7 @@ struct device *genpd_dev_pm_attach_by_name(struct device *dev, char *name)
>>
>> return genpd_dev_pm_attach_by_id(dev, index);
>> }
>> +EXPORT_SYMBOL_GPL(genpd_dev_pm_attach_by_name);
>
> Driver's shouldn't be calling this function, but instead use
> dev_pm_domain_attach_by_name().
>
> Is there any problem with that?
No not at all. Yes that works, sorry it had been a while since I looked
at this and managed to balls it up. OK, I will drop this and correct the
API used by the driver.
Cheers!
Jon
--
nvpublic
next prev parent reply other threads:[~2018-09-26 15:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 12:27 [PATCH 0/5] Tegra xHCI genpd support Jon Hunter
2018-09-26 12:27 ` [PATCH 1/5] PM / Domains: Export symbol for genpd_dev_pm_attach_by_name Jon Hunter
2018-09-26 14:09 ` Ulf Hansson
2018-09-26 15:02 ` Jon Hunter [this message]
2018-09-26 12:27 ` [PATCH 2/5] dt-bindings: usb: xhci-tegra: Add power-domain details Jon Hunter
2018-09-26 12:27 ` [PATCH 3/5] usb: xhci: tegra: Add genpd support Jon Hunter
2018-09-26 12:27 ` [PATCH 4/5] soc/tegra: pmc: Don't power-up XUSB power-domains Jon Hunter
2018-09-26 12:27 ` [PATCH 5/5] arm64: dts: tegra210: Add power-domains for xHCI Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afd04dd4-4199-9bb8-1b21-11444bb1773a@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox