From: Thierry Reding <thierry.reding@kernel.org>
To: shayderrr <darknessshayder@gmail.com>
Cc: thierry.reding@gmail.com, cyndis@kapsi.fi, airlied@linux.ie,
simona@ffwll.ch, dri-devel@lists.freedesktop.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] host1x: bus: Fix missing ops null check in error teardown
Date: Thu, 28 May 2026 15:30:22 +0200 [thread overview]
Message-ID: <ahhDR8dtEJ7Fpl3d@orome> (raw)
In-Reply-To: <20260517170456.84927-1-darknessshayder@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
On Sun, May 17, 2026 at 12:04:56PM -0500, shayderrr wrote:
> In host1x_device_init(), the error teardown paths do not check
> client->ops before dereferencing it, unlike the forward init paths
> which correctly guard with 'client->ops &&'. This can result in a
> NULL pointer dereference if client->ops is NULL.
>
> Fix by adding the missing client->ops check in both the teardown
> and teardown_late labels.
>
> Signed-off-by: shayderrr <darknessshayder@gmail.com>
> ---
> drivers/gpu/host1x/bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I don't think this can ever happen because all clients do implement the
ops structure, but since we have them in the code above, makes sense to
be consistent.
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-05-28 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 17:04 [PATCH] host1x: bus: Fix missing ops null check in error teardown shayderrr
2026-05-28 13:30 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahhDR8dtEJ7Fpl3d@orome \
--to=thierry.reding@kernel.org \
--cc=airlied@linux.ie \
--cc=cyndis@kapsi.fi \
--cc=darknessshayder@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox