From: Thierry Reding <thierry.reding@kernel.org>
To: Felix Gu <ustc.gu@gmail.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpu: host1x: mipi: Fix device_node reference leak in tegra_mipi_request()
Date: Thu, 28 May 2026 15:55:49 +0200 [thread overview]
Message-ID: <ahhJVgM4pd4ecg91@orome> (raw)
In-Reply-To: <20260416-mipi-v1-1-9c027175abdf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On Thu, Apr 16, 2026 at 08:09:29PM +0800, Felix Gu wrote:
> In tegra_mipi_request(), when provider.np is not equal with args.np, it
> returns without calling of_node_put(args.np), causing a reference leak.
>
> Convert to use the existing goto out pattern to ensure proper cleanup.
>
> Fixes: 767598d447aa ("gpu: host1x: mipi: Update tegra_mipi_request() to be node based")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> ---
> drivers/gpu/host1x/mipi.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-05-28 13:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 12:09 [PATCH] gpu: host1x: mipi: Fix device_node reference leak in tegra_mipi_request() Felix Gu
2026-05-28 13:55 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahhJVgM4pd4ecg91@orome \
--to=thierry.reding@kernel.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=simona@ffwll.ch \
--cc=skomatineni@nvidia.com \
--cc=treding@nvidia.com \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox