From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D4083F0AAF for ; Thu, 2 Jul 2026 11:23:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782991387; cv=none; b=RufZGqE/0jCN4+RdlQTRYJ6F5sHf/4UpaWqj9/UcZ8/Ft9EEgJznAwjdp5FjwW+NON0NxzaHKcUyXH6YI2oejPLOq76wvwZoonSERVfn+MZePELCUtuOhPxdm8bK+eaSEHH3IaDLUZGlS1G8nUgF0cTLpnxyV+wJzXoFODWezFQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782991387; c=relaxed/simple; bh=Cm3h5kw0hq4Y1dxxfDTE2i/+ct+FWNfrNzTgxOAOkUY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XvR0u+fJsXuQS8OZis2E4v2s0C3h5A3siCg/Vy2oYSmHkdI4EKCVFjx6/qD61dqgFI1zcZQxtuj8zZsJXsF1+jnj1qLHPmSDYygbDFsTFC688HARgPgQVDMtzSUhWfLd1KGp1FG0HTTXz1Qq4luGroCxY7MkadqDyTBkRTJD1SQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Ro4PTTVY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=6MM1Lq6H; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=GV/Itq01; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=5nYhQVu3; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Ro4PTTVY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="6MM1Lq6H"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="GV/Itq01"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="5nYhQVu3" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BFA6A7417E; Thu, 2 Jul 2026 11:23:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1782991383; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F7xaY1chatxMbDS+bkHdDKtz5gi7DevdjEG9fkMCV6s=; b=Ro4PTTVYWY+1Q+fSKwEyvVu2C8wg4A/3I9Q78iaZYGw4wsBf4KYe0OjW/ycxajPQ+NinaV U+7AQsUiUzpmFuQW/oC4SHwm2oHtjCqvi8LHkj68eHuO6Ksqvr1sL+WX60ZsbMFQN4KMst xTAmxu8wNPqPfjnqdMkbdmwQi3Caduk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1782991383; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F7xaY1chatxMbDS+bkHdDKtz5gi7DevdjEG9fkMCV6s=; b=6MM1Lq6HQfyxs23J5i59XCUkYNE2uNE4hmunNf3pUp3/RQC4CiUp48fbAw7FGDghW9TAgJ NHrffu9XmvyHcgCw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="GV/Itq01"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=5nYhQVu3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1782991382; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F7xaY1chatxMbDS+bkHdDKtz5gi7DevdjEG9fkMCV6s=; b=GV/Itq01reePFivyP3CzosxcP5ecDENo4J5Kb17SNf2kRfHaporyigMdzRpOwyOqbJKxMT yNQAHWPINUpghfaUYXSCO0RuwIer22uaBWzD7KSeu9/4sqjBPRzEJ7tnmgoiLkyTh0CcJe W/nOvqyP59iPAm2xDJhADX3K4PTVAcY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1782991382; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F7xaY1chatxMbDS+bkHdDKtz5gi7DevdjEG9fkMCV6s=; b=5nYhQVu33i5FNBtO6J/0n4fnuPm9MNAx2mPkD+UuzyB0lIrDOEiiXfZF1wNHS7blpDFYY9 /SawYRTr7rSaIHCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 58DC0779AA; Thu, 2 Jul 2026 11:22:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rIgoEhJKRmoEcAAAD6G6ig (envelope-from ); Thu, 02 Jul 2026 11:22:58 +0000 Date: Thu, 2 Jul 2026 12:22:56 +0100 From: Pedro Falcato To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 22/30] mm/vma: move __install_special_mapping() to vma.c Message-ID: References: Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Queue-Id: BFA6A7417E X-Spam-Flag: NO X-Spam-Score: -3.01 X-Spam-Level: X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_CC(0.00)[linux-foundation.org,armlinux.org.uk,kernel.org,siemens-energy.com,hansenpartnership.com,gmx.de,redhat.com,alien8.de,linux.intel.com,mev.co.uk,visionengravers.com,pengutronix.de,gmail.com,ffwll.ch,suse.de,oss.qualcomm.com,ideasonboard.com,nvidia.com,amd.com,shazbot.org,zeniv.linux.org.uk,linux.dev,google.com,infradead.org,samsung.com,goodmis.org,huawei.com,vger.kernel.org,lists.infradead.org,lists.freedesktop.org,lists.linux.dev,kvack.org,googlegroups.com,surriel.com]; DKIM_TRACE(0.00)[suse.de:+]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_GT_50(0.00)[75]; TAGGED_RCPT(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:email,suse.de:dkim,pedro-suse.lan:mid] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org On Mon, Jun 29, 2026 at 01:23:33PM +0100, Lorenzo Stoakes wrote: > This function is operating on VMAs and rightly belongs in vma.c, where it > can be subject to VMA userland testing and allows us to isolate it from the > rest of mm. > > The _install_special_mapping() function will remain in mmap.c as a wrapper, > since this is used by architecture-specific code. > > Doing so allows us to isolate more functions in vma.c for the same reasons. > > This forms part of work to allow for tracking MAP_PRIVATE file-backed > mappings by their anonymous virtual page offset, as doing so allows us to > isolate and keep code that interacts with this together. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes > --- > mm/mmap.c | 38 -------------------------------------- > mm/vma.c | 38 ++++++++++++++++++++++++++++++++++++++ > mm/vma.h | 5 +++++ > 3 files changed, 43 insertions(+), 38 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 2d09a57e3620..46174e706bbe 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -1447,44 +1447,6 @@ static vm_fault_t special_mapping_fault(struct vm_fault *vmf) > return VM_FAULT_SIGBUS; > } > > -static struct vm_area_struct *__install_special_mapping( > - struct mm_struct *mm, > - unsigned long addr, unsigned long len, > - vm_flags_t vm_flags, void *priv, > - const struct vm_operations_struct *ops) > -{ > - int ret; > - struct vm_area_struct *vma; > - > - vma = vm_area_alloc(mm); > - if (unlikely(vma == NULL)) > - return ERR_PTR(-ENOMEM); > - > - vma_set_range(vma, addr, addr + len, 0); > - vm_flags |= mm->def_flags | VM_DONTEXPAND; > - if (pgtable_supports_soft_dirty()) > - vm_flags |= VM_SOFTDIRTY; > - vm_flags_init(vma, vm_flags & ~VM_LOCKED_MASK); > - vma->vm_page_prot = vm_get_page_prot(vma->vm_flags); > - > - vma->vm_ops = ops; > - vma->vm_private_data = priv; > - > - ret = insert_vm_struct(mm, vma); > - if (ret) > - goto out; > - > - vm_stat_account(mm, vma->vm_flags, len >> PAGE_SHIFT); > - > - perf_event_mmap(vma); > - > - return vma; > - > -out: > - vm_area_free(vma); > - return ERR_PTR(ret); > -} > - > bool vma_is_special_mapping(const struct vm_area_struct *vma, > const struct vm_special_mapping *sm) > { > diff --git a/mm/vma.c b/mm/vma.c > index cb7222e20c93..f4de706a2728 100644 > --- a/mm/vma.c > +++ b/mm/vma.c > @@ -3399,3 +3399,41 @@ __weak unsigned long vma_mmu_pagesize(struct vm_area_struct *vma) > { > return vma_kernel_pagesize(vma); > } > + > +struct vm_area_struct *__install_special_mapping( > + struct mm_struct *mm, > + unsigned long addr, unsigned long len, > + vm_flags_t vm_flags, void *priv, > + const struct vm_operations_struct *ops) > +{ > + int ret; > + struct vm_area_struct *vma; > + > + vma = vm_area_alloc(mm); > + if (unlikely(vma == NULL)) > + return ERR_PTR(-ENOMEM); > + > + vma_set_range(vma, addr, addr + len, 0); > + vm_flags |= mm->def_flags | VM_DONTEXPAND; > + if (pgtable_supports_soft_dirty()) > + vm_flags |= VM_SOFTDIRTY; > + vm_flags_init(vma, vm_flags & ~VM_LOCKED_MASK); > + vma->vm_page_prot = vm_get_page_prot(vma->vm_flags); > + > + vma->vm_ops = ops; > + vma->vm_private_data = priv; > + > + ret = insert_vm_struct(mm, vma); > + if (ret) > + goto out; > + > + vm_stat_account(mm, vma->vm_flags, len >> PAGE_SHIFT); > + > + perf_event_mmap(vma); > + > + return vma; > + > +out: > + vm_area_free(vma); > + return ERR_PTR(ret); > +} > diff --git a/mm/vma.h b/mm/vma.h > index 47fe35e5307e..14f026bf3be4 100644 > --- a/mm/vma.h > +++ b/mm/vma.h > @@ -775,4 +775,9 @@ static inline bool map_deny_write_exec(const vma_flags_t *old, > } > #endif > > +struct vm_area_struct *__install_special_mapping(struct mm_struct *mm, > + unsigned long addr, unsigned long len, > + vm_flags_t vm_flags, void *priv, > + const struct vm_operations_struct *ops); > + > #endif /* __MM_VMA_H */ I'm really annoyed that _install_special_mapping has a leading underscore. That's it. Reviewed-by: Pedro Falcato -- Pedro