From: Thierry Reding <thierry.reding@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Lyude Paul <lyude@redhat.com>,
Danilo Krummrich <dakr@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Aaron Kling <webgeek1234@gmail.com>,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: gpu: nvidia,gk20a: Allow a fuse clock after the reference clock
Date: Tue, 13 Oct 2026 17:36:09 +0200 [thread overview]
Message-ID: <as5N73fHztX8hVWh@orome> (raw)
In-Reply-To: <20261013145210.103565-1-sashal@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1875 bytes --]
On Tue, Oct 13, 2026 at 10:52:08AM -0400, Sasha Levin wrote:
> GM20B needs both its reference clock and the fuse clock while it is
> powered, so allow "fuse" as a fourth clock after "ref".
>
> Assisted-by: LLM
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml
> index 4d856a8b674c..ecbc20e6adec 100644
> --- a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml
> +++ b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml
> @@ -44,6 +44,7 @@ properties:
> - description: GPU clock
> - description: Power clock
> - description: Reference or fuse clock
> + - description: Fuse clock
>
> clock-names:
> minItems: 2
> @@ -51,6 +52,7 @@ properties:
> - const: gpu
> - const: pwr
> - enum: [ ref, fuse ]
> + - const: fuse
Technically this now allows:
clock-names = "gpu", "pwr", "fuse", "fuse";
I think we may need a very explicit version to cover this now, something
like:
clock-names:
oneOf:
# for GK20A, GP10B, and GV11B
- minItems: 2
items:
- const: gpu
- const: pwr
- const: fuse
# for GM20B
- minItems: 3
items:
- const: gpu
- const: pwr
- const: ref
- const: fuse
We may also want to leave out the minItems property because it turns out
the FUSE clock is indeed required, so we'll need to add it to all device
trees anyway to fix this hang.
The exact list of items could also go into the per-SoC/GPU conditional
sections to be very exact.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-10-13 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 14:52 [PATCH 1/3] dt-bindings: gpu: nvidia,gk20a: Allow a fuse clock after the reference clock Sasha Levin
2026-10-13 14:52 ` [PATCH 2/3] arm64: tegra: Add the fuse clock to the Tegra210 GPU Sasha Levin
2026-10-13 15:37 ` Thierry Reding
2026-10-13 14:52 ` [PATCH 3/3] drm/nouveau/tegra: Keep the fuse clock enabled while the GPU is powered Sasha Levin
2026-10-13 15:44 ` Thierry Reding
2026-10-13 15:36 ` Thierry Reding [this message]
2026-10-13 15:46 ` [PATCH 1/3] dt-bindings: gpu: nvidia,gk20a: Allow a fuse clock after the reference clock Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as5N73fHztX8hVWh@orome \
--to=thierry.reding@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mperttunen@nvidia.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=robh@kernel.org \
--cc=sashal@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox