From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=52.101.193.4 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1793644320; b=GY2IddvfRXdJmV4Ys8BlE1HLR69rhTKhE2BY+Gv6jHVxWgZEaoZ9MJqLIiuRmRZ4Ev2R QjhKSXdK/PzEQwJOsBaJ++x3mvq/S6kCAx3yUsOfrrGQgfHSWgzd+WSlqxWQQp/oqby0N NI6stE1l9C/3MJcTAkBPwYMtDoDj+T6Dk4r/keFojRT6M8ip/HZWYMjfHATkcDl8iSZb/ VoAWQKuiMj5SU6hUuo/iHiI+f2FrHYJrleWFN2ayddTQa+x9P08e4/LQXn7uXAhVv8LtL BvewovOaoafhoOMPB9Ebwvb+NHJuUvyXvBi78jvWv+yeYVMT+3+3rT3hVWZBDEq3KCg== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793644320; h=DMARC-Filter:DKIM-Signature:Received:Received: X-MS-Exchange-Authentication-Results:Received-SPF:Received:Received: Received:Received:Date:From:To:CC:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To: X-NV-OnPremToCloud:X-EOPAttributedMessage:X-MS-PublicTrafficType: X-MS-TrafficTypeDiagnostic:X-MS-Office365-Filtering-Correlation-Id: X-MS-Exchange-SenderADCheck:X-MS-Exchange-AntiSpam-Relay: X-Microsoft-Antispam:X-Microsoft-Antispam-Message-Info: X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-OriginatorOrg: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-Id: X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-Transport-CrossTenantHeadersStamped; bh=XtdDfVPsMN36q2fjhM7w8igynxRl1pFxGYhtL5UkQ+c=; b=agmFa7uY/sOZ+zNFd4VevxQBNf8d3MV5Be8dXH1dcUVrwOEkggp3d/yDbXhD5TIgVy2b yCwl5DsbpqSznu6YPSza4joDQZ2MjfuDdgzOwhAdokTni/pB6AdSh09dbR+Q4IgJv73SN pmj0+UU4pm+z5TAG1hu1MjiINYVw+I0IB8BbyqeuM37rB1QKYhZjlp569p2Ur37m0hZLv EoBd2jyP5HmuEIgbXTsbPVIDg69tzMv/GfXq7jxZxA4zXBLiVZSQqvAkgGtP0WUEKX6NO Fg8igMPCglt3cXvXSr7PTJgQVk1BBqpbBQv7OBfmNEU5fLgaNtEjOjPRoiyNUPbGIJQ== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=D3wrzLXf; arc=pass header.oldest-pass=0 smtp.remote-ip=52.101.193.4 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010004.outbound.protection.outlook.com [52.101.193.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEADB606A326; Mon, 2 Nov 2026 18:31:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BEADB606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=D3wrzLXf ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vAMRjyTPOQwpB+knW9aPo9ib3o4b7LuHWVoEx7xj3B5fKMkf656BGuPrAqKlVwx5hwTXNriS8++wDITBpUNS7LLVc2IfaIymTWP/t11R+3Ue3MRouHO4OazvkufNoqrjkve9jKhFJVyIeQFE4yo/8lehY1dc16vzdpXXGUA2YkHxB6LXToYI4F5Uy9KrPMRcczyyBIoZ8Kugk9e6eSfZ1Y10D3frNOtGpNh4glDRdQvZELxaAl33Yh0/3mv/sFtxSXTo0ejKKA3KDskjBYPBQ31HwX0ribwVZFBX0kqNkJonQ7HCZjudGGU8J6sw1ItocXBHVpzRYtiCZ/NgRRi8dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XtdDfVPsMN36q2fjhM7w8igynxRl1pFxGYhtL5UkQ+c=; b=zDEqPnI2uLAq3YzoocN9sjGf8/wJWi3126Q5qRLRtK3XC3RE799/1M/Na0t9rT1OvePpsq9raCaBmJ4A3i7GR+hOvjn0SP9YdSJKIido6BW+hVEauV+1Lb8Q0BL+DJF1TOdBbTPB/vsflMi+0NMBHYmtCvrdKgr75kZfoJx/pNxKmv2LtpZK4ktuMwm99pJvISMEq62sFKvsGajufQVapjKg1AtTZWEWcwmzcB3TPnTrDfzfeCGcogd9aVQQAXMQl8ImGJYBGwyadCREX7Dfed2QbRVo3ORbexLTpHbLdF4Uro/yncVUyL/E36OoI4TTSAutps7anNS5yxo2fSs9Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=oss.nxp.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XtdDfVPsMN36q2fjhM7w8igynxRl1pFxGYhtL5UkQ+c=; b=D3wrzLXfdfkoD9KgKbJ0MbLsD8zgy1GZylL0kFaVPVzUqtdSQvtqFY6aJpVlyfiAn/b66LFxG7sZ8tIm4zHt7wy7IdN2O5Mj2u4oCnOtxdY1vFgystLrE2E2O2JuvEhF8VQujJf6Y9Yfg0C97gEDzl9bZdGy/xQ0AgrYVJT/RNUBL6VNit6YgkR3F52BVrk4/+pcLGMu6/o+AnhGFs0iAGhABMVWA0ckvbje6LcVnoXDQj8jr1Zo213SEb7bcwlicmBLh2Vk9/Y448skJBCyr/+HQ4rDtz/Ut2tQ27r3FENb/mtCdpNjiWoYp8iDCOMOQS4b0s6nYqyJpuY6KxJ4mw== Received: from MW4PR04CA0377.namprd04.prod.outlook.com (2603:10b6:303:81::22) by LV3PR12MB9412.namprd12.prod.outlook.com (2603:10b6:408:211::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 18:31:54 +0000 Received: from MWH0EPF000C6192.namprd02.prod.outlook.com (2603:10b6:303:81:cafe::54) by MW4PR04CA0377.outlook.office365.com (2603:10b6:303:81::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.12 via Frontend Transport; Mon, 2 Nov 2026 18:31:54 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by MWH0EPF000C6192.mail.protection.outlook.com (10.167.249.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Mon, 2 Nov 2026 18:31:54 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.56; Mon, 2 Nov 2026 10:31:30 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.56; Mon, 2 Nov 2026 10:31:29 -0800 Received: from nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.56 via Frontend Transport; Mon, 2 Nov 2026 10:31:28 -0800 Date: Mon, 2 Nov 2026 10:31:26 -0800 From: Nicolin Chen To: "Peng Fan (OSS)" CC: Will Deacon , Robin Murphy , "Jason Gunthorpe" , "Joerg Roedel (AMD)" , "Thierry Reding" , Krishna Reddy , Jonathan Hunter , Jean-Philippe Brucker , , , , , Peng Fan Subject: Re: [PATCH RFC v7 6/7] iommu/arm-smmu-v3: Group aliasing devices into the same IOMMU group Message-ID: References: <20261030-smmu-shared-sid-ver7-2026-10-26-v7-0-961726ebd6ab@Example.Com> <20261030-smmu-shared-sid-ver7-2026-10-26-v7-6-961726ebd6ab@Example.Com> X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20261030-smmu-shared-sid-ver7-2026-10-26-v7-6-961726ebd6ab@Example.Com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6192:EE_|LV3PR12MB9412:EE_ X-MS-Office365-Filtering-Correlation-Id: 13de14fe-a38e-4cb5-a323-08df390f91c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|7416014|36860700016|23010399003|18002099003|56012099006|261102123227099003|22082099003|261022105027099003|261021135927099003|261021121427099003|11063799006|4143699003|10067099003|261028144727099003|261026121527099003|261026140227099003; X-Microsoft-Antispam-Message-Info: Fukb3nM5hrA0KHG+uMUtrpb1epSBhZAzM4nVQwDgh0TqX0BvpAhPhlWwAhBmEeuRCBDBlm5fLjrYkpOZ2TePSk41GLxJSjhz06XwXaUfSmt4d6B56Btu9zspjU+P9D0coyWjbZLN68JmuvO2hW+2M6SQuxEwGeFsNePVzl9Qjf/AI0fq0kJwOorfNFRaQGOrGaXGMuoI529miK9jx6Kqdf4dKVQ227Dr42GrK1sbcRrjNmw+X8ZwKS9ZKv0MaMITyaDvlkwjAMRzxy4NTsfnClXyVp4GXvRlDvuYfk0NB0+PCgcfIiKrkP2hEFNEaurGyr8G8EtVJM9eL/I5mLQZ0B/HuG4TSQ7bBTB8py5BupTYFvRMnGKEHjp5lNUjilVIalSeBLe0XMQkYU0/+FbRhtd3o7s026So+mQf71cOXNy9LrJr/4BZPTUwLukEQyS0iOiZLQO+cVvPH1254HkghrcN21Pnqg9cORaWNjROBDfyEL33FdsCnrJYDy3ESkbZBlc6F/GqIJD25SzSMr5GYDtUnH1HYJe+svi+zNgC+lAiecjU1MBQeMTkt5uUzJGmlpCurd5DvEAl1IQxxvAfIoR436lTHU7ZqIjuEdd6gaQ85IpKaZLFhY81HGTHERQp1r2DILGDQMP3R7CW1eCun+4IGWBIamJp/m8R8XP10dPsxevXSQkv0BFFhUAY95YBTS9SIL3qdJKpMlgzZMPH3w== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(7416014)(36860700016)(23010399003)(18002099003)(56012099006)(261102123227099003)(22082099003)(261022105027099003)(261021135927099003)(261021121427099003)(11063799006)(4143699003)(10067099003)(261028144727099003)(261026121527099003)(261026140227099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: d5QfapfVihS9pUQD2ysdydnlafo2uOl64vkWr8W9ZqBxei9P5m9UWj2lJe5wGrtqMA/l7/qSNOonM6bIq43Vt/rlF26JlPdS12kgUt8WmAhy+yiRhVeMFfxxmNho3HrKBbvf9IVLKBJSanQSFvsrvdUuFJsj5swClOvg1nFeOVBqt7VMzOHFh/0YdjjxXGXcXOSuZ2ADkOt4y6Ky80WVpkLGV4546aAmb00SWwBN8kR548MzUR7vfMq6qVewgzvTxwnuDKE/g5pp2zfkfMPKIkK1XXlQ0FrD3NiOpUpKNd19I6HTUBj3CqhHDmYCdWU+JkexqZXuI0bixQ+mFl5qJ091iTDOdFGidzJapcNySMeDxzpVP4K+QkBnGnVJ9sdrZw7Se+ZDjxUOSAzR0v/6pbwi2oNGdWqbaOzR+LO5KjGmE0ng6jXQN9Ey7s2sdkLu X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 18:31:54.1852 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 13de14fe-a38e-4cb5-a323-08df390f91c4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6192.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9412 On Fri, Oct 30, 2026 at 08:09:38PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Devices sharing a SID must share a single IOMMU domain because the STE > can only point to one CD table at a time. With the domain-owned CD table, > non-PASID devices in that domain share that table directly. > > Detect SID aliasing at group-assignment time by looking up the RB tree > for existing owners. Since probe_device() inserts the master before > device_group() is called, skip the device's own stream and look for a > different, already-probed master that shares the same SID. > > Signed-off-by: Peng Fan Reviewed-by: Nicolin Chen With a nit, > if (dev_is_pci(dev)) > - group = pci_device_group(dev); > - else > - group = generic_device_group(dev); > + return pci_device_group(dev); > > - return group; > + return generic_device_group(dev); This change seems unnecessary. Nicolin