From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794914692; b=Nnv+qX3ALtuFbj04i/hBhHvIV6XGKt5F9UD2zyJv73MUIKjr917ycNWD2bLB0mdTWNtM +nHZP5tZRDTOyYngP1sFI+wlvISh990VEeX1ajY1HSRPW7R7K/VVp3rFlvJGhV8Tkoj9g rPD+tt5NtANGVk2K/O4zDnzxM9NVZJAw+y7kQroUhjxam91LpMLkDHCH66ei4tjTckdxf uvazvqH5Ixg1nfhwo+FVSUA9AasRthodLA57+vmqI0Qgx9S5DRFYeZcbMvB0lF09PuwrR uBzsdi0b8SSfnkaYOc1Oa+S2L57n/eTX+cvejQX4Z2ScqkRTMZogxuHepMGu5/cKnHA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794914692; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=vWOxMHWlcWtp27VVdwB8K8C+YGb+xa1iSkIZnmlgfTA=; b=jafY04Knx2txv39GnvvLtzE/nPwRPk0AHK9CKZ6dIPgwYn/RDpLXkp4rT68+VOJkRzP0 a2uXDBZh5L3jaNxTcYtA2oxbyPSAuxqhm6Nfn1/FUaENkwQaZBd0s2LoivzhyfScd+gUw xGV1U9tMRdiWn0A2RxSMkNOBr3RMQTylOxYlEhgHkH4N8vEisc8rbtl1JLf57h7An/qIb XVRdV8Rgv8F37Euv7x7YfK1V8z2RTgNrvOK45P8+AMo/8y5Tn24+4uhcX799/QqE7Zz3x 3ksLZEO/U6TaWwXB79bxZCvJCWZv7aB7hO8iBOeChxHlklZ7dy52X7Prteg3mgopyWA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=DhgxR9Wo; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA228606A32A for ; Tue, 17 Nov 2026 11:24:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=DhgxR9Wo Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE1B91F000C4; Tue, 17 Nov 2026 11:24:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794914692; bh=vWOxMHWlcWtp27VVdwB8K8C+YGb+xa1iSkIZnmlgfTA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=DhgxR9Wo+dUuqkYWxNm8rH7ej9OWfhE/Xv8DnoobJmZZLPkYsdBJo5fCkCZJFSl4t gwGGW5A9I9pO32K4YLEJ21S1X1QscsjDvk9tYDpyVp11eavqV0M+giyonO4WQ9luHS 5AElNQ21OYGOL+Scg06kyjBswlpqwU2uTVobkQZKp/xMBI0CqlAb18JPvqRawXRLFp frySI+jf1vEbDNQ7Y7x75M3uceernjmsj2cRQuY0uX1RHS+OYO9MOFD75qofuEO9AU UUoIry2Wm88kf3dDuVi67A1d0DM7gEyQwu0X5yMLyoIdz5Getfbw0SIvcyO35O7Rh8 sTzKdEBXgCMLQ== Date: Tue, 17 Nov 2026 12:24:49 +0100 From: Thierry Reding To: Maxime Ripard Cc: David Airlie , Maarten Lankhorst , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org, Jonathan Hunter , Mikko Perttunen , linux-tegra@vger.kernel.org Subject: Re: [PATCH RESEND 53/83] drm/tegra: Switch to drm_mode_config_create_initial_state Message-ID: References: <20261105-drm-no-more-config-reset-v1-0-1f58d1e33380@kernel.org> <20261105-drm-no-more-config-reset-v1-53-1f58d1e33380@kernel.org> X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zcuoxflydzito32u" Content-Disposition: inline In-Reply-To: --zcuoxflydzito32u Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH RESEND 53/83] drm/tegra: Switch to drm_mode_config_create_initial_state MIME-Version: 1.0 On Tue, Nov 10, 2026 at 05:10:01PM +0100, Maxime Ripard wrote: > Hi Thierry, >=20 > On Thu, Nov 05, 2026 at 04:51:46PM +0100, Thierry Reding wrote: > > On Thu, Nov 05, 2026 at 04:30:02PM +0100, Maxime Ripard wrote: > > > drm_mode_config_reset() has a dual role: it creates the initial KMS > > > state at probe time, and resets hardware and software state during > > > suspend/resume cycles. > > >=20 > > > Since the two roles need different behaviors (notably for objects like > > > drm_private_obj that must persist across suspend/resume), > > > drm_mode_config_create_initial_state() was introduced to handle only > > > the initial state creation at probe time. > > >=20 > > > Switch to drm_mode_config_create_initial_state(). > > >=20 > > > Signed-off-by: Maxime Ripard > > > --- > > > Cc: Jonathan Hunter > > > Cc: Mikko Perttunen > > > Cc: Thierry Reding > > > Cc: linux-tegra@vger.kernel.org > > > --- > > > drivers/gpu/drm/tegra/drm.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > >=20 > > I'd have to check more closely since it's been a while, but I think we > > might depend on the reset hooks getting called during probe. > >=20 > > Looking at the implementation of drm_mode_config_create_initial_state(), > > it ends up calling drm_mode_config_connector_create_state(), which > > silently exists if the connector doesn't implement atomic_create_state, > > which none of the Tegra connectors do, so wouldn't that lead to a NULL > > pointer dereference at some point? >=20 > AFAIK, all tegra connectors have now been converted to > atomic_create_state instead of reset (commits c5c0e4821938 and > f808d9f8e5a3 in drm-misc-next) so it shouldn't have any reset specific > behaviour at all and the transition to > drm_mode_config_create_initial_state(). >=20 > Am I missing something? Ah, I don't think they were in linux-next (which is what I was looking at) yet when I replied. Looks like it should be fine now: Acked-by: Thierry Reding --zcuoxflydzito32u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmr8OYEACgkQ3SOs138+ s6HwgQ/9F/dU5Fwj1VmRt0XTem4o41tqgkGUsXzETd3U/l9jBb8BRnZCRYtlml/R oT62Ai/D0zJkNBKKhjlykcGYDf4vTd47uor5P6/VgBHbuAfJBOmsRD944bL6Mi5t crpiyXqWQGbzFxz+We9vGBbI6KdE6czvrb/jU8SJ2gzWMHltmP3/n++F2FOL3WHf yAB79ZWQYEXNgoMsC+Q8uvs2KEANEPgjZ9HNLsq4EcP8bqfPFf86DSQn/oe5Fio0 MYrmlYsVm4qGiFHQwNVtage4A6d8djYn2szn/3D3nHvLyj4cGnsxI68XZ5tjSRAc rhv/pl3QgbatOqJcP4m4aNK8/adgzV+iR0s/tAB4ET3uuyL4NjFtr9rCukIo34Gq +6okBMrL7D0NDOTV6zgJufjcWYkTmylhWu4EjYYiros9gTzCkpcJH68qkNjN8VLF dwVB9iz2KOEWyCXny7bbInyp/TyUq2gQRFAYW3XrG4WI4LZFyNO/qUNE63MY9+ut OjhX3R7XpuSBRHJNEfQEvcbDNoiOiVdyU/MXvu8TrFLUjF5auQ4NEijJ3aLIf58M XAquAAilfek9lTtxHMkbvdnLwQH8ib1EcctBBx8heJRLytrcwGiWIlejoT0N1JGv Nsen3WczV/1YgYc6RLUc/fN9URshi5H1zm/WlH559Sk5UDGNMPc= =tQ8v -----END PGP SIGNATURE----- --zcuoxflydzito32u--