Linux Tegra architecture development
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@kernel.org>
To: Lee Jones <lee@kernel.org>
Cc: Linus Walleij <linusw@kernel.org>,
	 Jonathan Hunter <jonathanh@nvidia.com>,
	Aaron Kling <webgeek1234@gmail.com>,
	linux-gpio@vger.kernel.org,  linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 02/10] pinctrl: tegra186: Fix out-of-bounds register bank index for AON drive groups
Date: Tue, 17 Nov 2026 12:46:49 +0100	[thread overview]
Message-ID: <avw8tOcBNMPwS_z5@orome> (raw)
In-Reply-To: <20261103213002.1673560-3-lee@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

On Tue, Nov 03, 2026 at 09:29:07PM +0000, Lee Jones wrote:
> The Tegra186 AON pinmux controller has only a single register bank
> (nbanks = 1, indexed at 0), and all PINGROUP entries in tegra186_aon_groups
> accordingly specify bank 0.  However, all 51 AON drive_* macro definitions
> pass drv_bank = 1 as the final argument to DRV_PINGROUP_ENTRY_Y, causing
> any drive configuration read or write on an AON drive group to index
> pmx->regs[1] out-of-bounds.
> 
> Update the AON drive_* macro definitions to use register bank 0.
> 
> Fixes: 542baf77f092 ("pinctrl: tegra: Add Tegra186 pinmux driver")
> Closes: https://sashiko.dev/#/bug/linux-a9a7165c-c5eb-463a-b7b1-24a30416b33b
> Cc: stable@vger.kernel.org
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
>  drivers/pinctrl/tegra/pinctrl-tegra186.c | 102 +++++++++++------------
>  1 file changed, 51 insertions(+), 51 deletions(-)

Yeah, looks correct. It looks like this wasn't tested at all since the
time this was merged. I'll add this to the list of things that need to
have a test added.

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-11-17 11:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 21:29 [PATCH 00/10] pinctrl: Fix out-of-bounds accesses, divide-by-zero, and error handling Lee Jones
2026-11-03 21:29 ` [PATCH 02/10] pinctrl: tegra186: Fix out-of-bounds register bank index for AON drive groups Lee Jones
2026-11-17 11:46   ` Thierry Reding [this message]
2026-11-17 12:22     ` Lee Jones
2026-11-05  9:16 ` [PATCH 00/10] pinctrl: Fix out-of-bounds accesses, divide-by-zero, and error handling Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avw8tOcBNMPwS_z5@orome \
    --to=thierry.reding@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=lee@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=webgeek1234@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox