public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>,
	Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org
Subject: Re: [PATCH] soc/tegra: pmc: Add reboot notifier
Date: Thu, 18 Nov 2021 22:13:34 +0300	[thread overview]
Message-ID: <b0274558-7ad3-bc56-01ea-eb9f89716c24@gmail.com> (raw)
In-Reply-To: <20211115113208.237296-1-jonathanh@nvidia.com>

15.11.2021 14:32, Jon Hunter пишет:
> -static int tegra_pmc_restart_notify(struct notifier_block *this,
> -				    unsigned long action, void *data)
> +static void tegra_pmc_program_reboot_reason(const char *cmd)
>  {
> -	const char *cmd = data;
>  	u32 value;
>  
> +	if (!cmd)
> +		return;

There is no explanation of this change in the commit message. Previously
scratch register was cleared if command is NULL, now it's not. Why?

  reply	other threads:[~2021-11-18 19:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15 11:32 [PATCH] soc/tegra: pmc: Add reboot notifier Jon Hunter
2021-11-18 19:13 ` Dmitry Osipenko [this message]
2021-11-22 12:12   ` Jon Hunter
2021-11-22 12:37     ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0274558-7ad3-bc56-01ea-eb9f89716c24@gmail.com \
    --to=digetx@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox