From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH v1] memory: tegra: Don't invoke Tegra30+ specific memory timing setup on Tegra20 Date: Fri, 20 Jul 2018 09:02:04 +0100 Message-ID: References: <20180719132453.16860-1-digetx@gmail.com> <39607791-3e71-7784-37db-4e05a316d7a8@nvidia.com> <31916977.CHrX6e343J@dimapc> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <31916977.CHrX6e343J@dimapc> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Osipenko Cc: Thierry Reding , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On 19/07/18 16:38, Dmitry Osipenko wrote: > On Thursday, 19 July 2018 18:30:48 MSK Jon Hunter wrote: >> On 19/07/18 14:24, Dmitry Osipenko wrote: >>> This fixes irrelevant "tegra-mc 7000f000.memory-controller: no memory >>> timings for RAM code 0 registered" warning message during of kernels >>> boot-up on Tegra20. >> >> Looking at the tegra20-emc.txt bindings doc [0], the 'nvidia,ram-code' >> property is also valid for Tegra20. In fact, I see this warning on the >> Tegra30 Cardhu because this property is not populated. So I think that >> this warning is valid and harmless. >> >> Cheers >> Jon >> >> [0] Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-emc.txt > > That is the irrelevant binding, the relevant one for this driver is [0]. The > warning is valid for T30+, but not for T20. > > [0] Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.txt Yes indeed, looks like we never supported this for Tegra20. OK, fine with me I guess this was introduced during the consolidation of the MC drivers. Can you add the appropriate fixes tag? Otherwise ... Acked-by: Jon Hunter Cheers Jon -- nvpublic