From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH V19 1/7] i2c: tegra: sort all the include headers alphabetically Date: Wed, 13 Feb 2019 16:13:32 +0300 Message-ID: References: <1549998408-9137-1-git-send-email-skomatineni@nvidia.com> <20190213083519.tynjs3ef6tnvvsms@ninjato> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190213083519.tynjs3ef6tnvvsms@ninjato> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Wolfram Sang Cc: Peter Rosin , Sowjanya Komatineni , "thierry.reding@gmail.com" , "jonathanh@nvidia.com" , "mkarthik@nvidia.com" , "smohammed@nvidia.com" , "talho@nvidia.com" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" List-Id: linux-tegra@vger.kernel.org 13.02.2019 11:35, Wolfram Sang пишет: > >>> "^ Header removal should be mentioned in the commit message, I think." >>> - Wolfram Sang [0] >>> >>> Cheers, >>> Peter >>> >>> [0] https://lkml.org/lkml/2019/2/11/375 >>> >> >> It could make sense to adjust the comment only if there will be >> anything else worthwhile a new revision, otherwise it is >> not-so-important. > > Not quite. Addressing review comments and proper commit messages are > both important. So, it needs to be fixed. Yes, I can fix this small > issue locally here (and I will do this, so no need to resend), but this > is ultimately my decision (which you can surely ask for but not > rely on). > > I'll apply this series later today. > Fixing up minor itches while applying patches is the right approach, thank you!