From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, thierry.reding@gmail.com,
jonathanh@nvidia.com, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] arm64: tegra: Fix HSUART for Smaug
Date: Mon, 17 Jul 2023 10:03:19 +0200 [thread overview]
Message-ID: <b3755c4b-fee0-85e3-4066-fb20c1ad99a3@linaro.org> (raw)
In-Reply-To: <20230714101018.10617-1-diogo.ivo@tecnico.ulisboa.pt>
On 14/07/2023 12:10, Diogo Ivo wrote:
> After commit 71de0a054d0e ("arm64: tegra: Drop serial clock-names and
> reset-names") was applied, the HSUART failed to probe and the following
> error is seen:
>
> serial-tegra 70006300.serial: Couldn't get the reset
> serial-tegra: probe of 70006300.serial failed with error -2
>
> Commit 71de0a054d0e ("arm64: tegra: Drop serial clock-names and
> reset-names") is correct because the "reset-names" property is not
> needed for 8250 UARTs. However, the "reset-names" is required for the
> HSUART and should have been populated as part of commit a63c0cd83720c
> ("arm64: dts: tegra: smaug: Add Bluetooth node") that enabled the HSUART
> for the Pixel C. Fix this by populating the "reset-names" property for
> the HSUART on the Pixel C.
>
> Fixes: a63c0cd83720 ("arm64: dts: tegra: smaug: Add Bluetooth node")
> Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
> ---
> arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> index 2c608d645642..bcb533cc002c 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> @@ -1364,6 +1364,7 @@ serial@70006000 {
>
> uartd: serial@70006300 {
> compatible = "nvidia,tegra30-hsuart";
> + reset-names = "serial";
Why reset-names is board specific? This makes little sense. If you need
reset-names, then it is part of SoC.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-17 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 10:10 [PATCH] arm64: tegra: Fix HSUART for Smaug Diogo Ivo
2023-07-14 10:21 ` Jon Hunter
2023-07-14 14:41 ` Thierry Reding
2023-07-14 14:52 ` Thierry Reding
2023-07-17 8:03 ` Krzysztof Kozlowski [this message]
2023-07-18 7:59 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3755c4b-fee0-85e3-4066-fb20c1ad99a3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo@tecnico.ulisboa.pt \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox