From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: CGEL <cgel.zte@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Dmitry Osipenko <digetx@gmail.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
Jing Yangyang <jing.yangyang@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] memory:tegra210-emc-core: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
Date: Wed, 25 Aug 2021 12:23:59 +0200 [thread overview]
Message-ID: <b6d32023-e3ac-3ccc-e683-076768124bde@canonical.com> (raw)
In-Reply-To: <20210825100149.GR7722@kadam>
On 25/08/2021 12:01, Dan Carpenter wrote:
> On Wed, Aug 25, 2021 at 11:45:58AM +0200, Krzysztof Kozlowski wrote:
>> On 25/08/2021 08:37, CGEL wrote:
>>> From: Jing Yangyang <jing.yangyang@zte.com.cn>
>>>
>>> Fix the following coccicheck warning:
>>> ./drivers/memory/tegra/tegra210-emc-core.c:1665:0-23:WARNING
>>> tegra210_emc_debug_min_rate_fops should be defined
>>> with DEFINE_DEBUGFS_ATTRIBUTE
>>> ./drivers/memory/tegra/tegra210-emc-core.c:1726:0-23:WARNING
>>> tegra210_emc_debug_temperature_fops should be defined
>>> with DEFINE_DEBUGFS_ATTRIBUTE
>>
>> Thanks for the patch.
>>
>> One error message is enough. They are the same.
>>
>>>
>>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>>
>> Where is the report? We work here in a public, so if there is a report I
>> assume we can reach it? In case the report does not exist, anyone can
>> run checkpatch, coccinelle, smatch and sparse, so how does this differs
>> from me running checkpatch?
>
> Someone asked for these tags when it was Huawei sending patches from
> the Hulk Robot so no everyone adds them and Hulk Robot is the #1 bug
> reporter. Hulk Robot just crossed the 2000 tag mark recently.
Yes, I know, my questions where rather rhetorical. :) Hulk Robot reports
are ridiculous, in my opinion.
The tool (checkpatch) used to detect warning is public, so from
community perspective this does not differ from John Smith sending a fix
for a checkpatch issue.
However I do not expect tags like:
From: John Smith
...
Reported-by: John Smith
Signed-off-by: John Smith
How does it look? Neither I expect some unknown, hidden, secret reports
like:
Reported-by: foo bar
Signed-off-by: John Smith
Simply the credit of running the tool (e.g. checkpatch) is already in
the patch authorship. The Reported-by is for crediting additional work
related to the report.
No report, no credit. Otherwise the value of Reported-by cease to exist...
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-08-25 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 6:37 [PATCH linux-next] memory:tegra210-emc-core: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE CGEL
2021-08-25 9:45 ` Krzysztof Kozlowski
2021-08-25 10:01 ` Dan Carpenter
2021-08-25 10:23 ` Krzysztof Kozlowski [this message]
2021-09-15 7:37 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6d32023-e3ac-3ccc-e683-076768124bde@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=cgel.zte@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=digetx@gmail.com \
--cc=jing.yangyang@zte.com.cn \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox