From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 4/7] memory: tegra: Change macros to interpret parameter as integer
Date: Sat, 13 Apr 2024 10:02:07 +0200 [thread overview]
Message-ID: <b80aa6b2-2c55-4e6b-8882-e57634dfde15@linaro.org> (raw)
In-Reply-To: <20240409094632.62916-5-diogo.ivo@tecnico.ulisboa.pt>
On 09/04/2024 11:46, Diogo Ivo wrote:
> Convert the macros that manipulate the delay values to interpret their
> index parameter as an integer to allow the introduction of loops.
>
> Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
> ---
> drivers/memory/tegra/tegra210-emc-cc-r21021.c | 33 +++++++------------
> 1 file changed, 11 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/memory/tegra/tegra210-emc-cc-r21021.c b/drivers/memory/tegra/tegra210-emc-cc-r21021.c
> index a80c3b575612..65157bd5dc24 100644
> --- a/drivers/memory/tegra/tegra210-emc-cc-r21021.c
> +++ b/drivers/memory/tegra/tegra210-emc-cc-r21021.c
> @@ -75,29 +75,29 @@ enum {
> * The division portion of the average operation.
> */
> #define __AVERAGE_PTFV(dev) \
> - ({ next->ptfv_list[PTFV_DQSOSC_MOVAVG_ ## dev ## _INDEX] = \
> - next->ptfv_list[PTFV_DQSOSC_MOVAVG_ ## dev ## _INDEX] / \
> + ({ next->ptfv_list[dev] = \
> + next->ptfv_list[dev] / \
Aren't you missing now () over dev?
Are you sure this passes checkpatch --strict?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-13 8:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 9:46 [PATCH 0/7] Cleanup Tegra210 EMC frequency scaling Diogo Ivo
2024-04-09 9:46 ` [PATCH 1/7] memory: tegra: Remove periodic compensation duplicate calls Diogo Ivo
2024-04-09 9:46 ` [PATCH 2/7] memory: tegra: Move DQSOSC measurement to common place Diogo Ivo
2024-04-09 9:46 ` [PATCH 3/7] memory: tegra: Reword and correct comments Diogo Ivo
2024-04-09 9:46 ` [PATCH 4/7] memory: tegra: Change macros to interpret parameter as integer Diogo Ivo
2024-04-13 8:02 ` Krzysztof Kozlowski [this message]
2024-04-15 11:07 ` Diogo Ivo
2024-04-09 9:46 ` [PATCH 5/7] memory: tegra: Loop update_clock_tree_delay() Diogo Ivo
2024-04-09 9:46 ` [PATCH 6/7] memory: tegra: Move compare/update current delay values to a function Diogo Ivo
2024-04-13 8:07 ` Krzysztof Kozlowski
2024-04-15 11:17 ` Diogo Ivo
2024-04-09 9:46 ` [PATCH 7/7] memory: tegra: Rework update_clock_tree_delay() Diogo Ivo
2024-04-13 8:08 ` Krzysztof Kozlowski
2024-04-15 11:22 ` Diogo Ivo
2024-04-18 17:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b80aa6b2-2c55-4e6b-8882-e57634dfde15@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=diogo.ivo@tecnico.ulisboa.pt \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox