From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2085.outbound.protection.outlook.com [40.107.96.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6DC52EF293; Fri, 25 Jul 2025 15:58:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.96.85 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753459133; cv=fail; b=ecGc/weeX7RyUitn3nWgpZb5JdzTWKBMWA/Ky4sSUWLtUb7K2xtPWC/1E2s0K4x8cT+4TiosPEubYWWw2VxcyHnBYMOgmONmIsqgfQylEAnYUjnF9Or6apD7Yr0ldtz32+SSccftVB81ouHC8mVa0jl5fDtDNEzbluyfa8Zyz1M= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753459133; c=relaxed/simple; bh=jBgcwkgPrt4HLyD0Hibo872ezW44dEDtJ39uQzgyaOE=; h=Message-ID:Date:From:Subject:To:Cc:References:In-Reply-To: Content-Type:MIME-Version; b=EeDT2NMNSO9/0ybJeG24Is514Fpp9zh0Pgmua4kW0rLcNIeGOHKJMAHYx2DrJcPWqaMOvd1tVHbQXQRKzjgKihZfCeBv2jFbIjpux2cV7Itu3WoZMNfV2uu/iG/axuGil9i6aavlMbJNl7GmpVih8uaGmwu3PUR1IRsDarnfZVM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=slrZJjc/; arc=fail smtp.client-ip=40.107.96.85 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="slrZJjc/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oGJtLrKQ9Tlti8CtLofe9bT7G4ObobeyEt/zoMB9OzJoEjCzl3xkTdQNTbC7KIWJQt4h1+7hlkqJuxqXGFXvfZ1QONZbUycBMPc4IZbFqsSH6VEZK3rac597pJXI0qiksi3Vrv8UbbqUScnaeCu150gEmm2pNyfmCVcSQctJ9B7U3hkdsO86Ka+0+EWachMLxm9bNrbYy1TBk12vSKH1MZUhuuLESODmvLZTrUtvGY/wfoQy8ugu1+8O2qUIXto2BAtjCrVcKUNQDSXR0cgNNnlZJgu2Va/QglZuwX/zYOHaGEVD2SiysXbMljuTQQ5R9XH/gNo2QmLVtJKBpEHKUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HZtc3A/1+XU779WCc/25vqVFq8l9gEmxpBjAGWbf+qA=; b=AJsYiRZZhdWuUTWB7tJ31F7tb6eMWWyvs6N9CcNk/bmNDIL/HM+y2ovzCXpf9SbUeJwTnH6fT3KtHVjianTTyxNnsrYR/tJ1fefq5UKrn/pTVfG2kz6FBPqZz1nYjaSD4FuedwgTUAegVsmApLPiALqajUrEG+NSVHpjTCnX3kN/IxxPHUY/cbyt+7/4m+w1eDuYqQqWuoszCzTTlc+mFdTclM08nV4ndEzu2hYa9eiAjjUqCeUWfUk9hZDMyuFYkpCBn6qJfKubwv+SSysN2/qyzB3NJNN3gp3hSmJaNeFXXnL2Izp8kNw0+26+dJ7G1rN+f0ITksb4EsP0b1WULw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HZtc3A/1+XU779WCc/25vqVFq8l9gEmxpBjAGWbf+qA=; b=slrZJjc/gBsc7BXsnD1q1qy9kyt9NgKqmmIvbh7gwjlAEZ0E4s9kZ7jKFTSRaNirQn4r7CwkRYJ53olCoYsdYsl8pYwLTFClL8iVsxoJP2Cc4TBn5uMEt3cKcYEyW6bC/3bcsImoKPwAwLWW+TVftUwrr31XGQzkTSIPvRaRsTheeuBU++MTmbmegUmkIBO19RRq/y7lw/dCOiq1KGgrKsUsOO6m7r+0D0Qi9RcwkILXEEboJVDk8DbubvOqSTjIBdnJf0gJ/H57cpC8b8SMUdLGjVac9maUBTXl7swF0XKc7tuLaNQGXsrb7dvLMW4+TwwpAnOUuhOk4DsFhoIIYw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH8PR12MB9768.namprd12.prod.outlook.com (2603:10b6:610:260::9) by DM4PR12MB6422.namprd12.prod.outlook.com (2603:10b6:8:b9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.22; Fri, 25 Jul 2025 15:58:46 +0000 Received: from CH8PR12MB9768.namprd12.prod.outlook.com ([fe80::f7db:9f0:a574:1abf]) by CH8PR12MB9768.namprd12.prod.outlook.com ([fe80::f7db:9f0:a574:1abf%7]) with mapi id 15.20.8964.023; Fri, 25 Jul 2025 15:58:46 +0000 Message-ID: Date: Fri, 25 Jul 2025 21:28:32 +0530 User-Agent: Mozilla Thunderbird From: Shubhi Garg Subject: Re: [PATCH v5 1/4] dt-bindings: rtc: Document NVIDIA VRS RTC To: Jon Hunter , Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Alexandre Belloni , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, linux-tegra@vger.kernel.org, Shubhi Garg References: <20250723130343.2861866-1-shgarg@nvidia.com> <20250723130343.2861866-2-shgarg@nvidia.com> <20250724-peridot-chachalaca-of-progress-a9f2ee@kuoka> <2c59e665-6415-460b-8ff8-c06f8d94f9eb@nvidia.com> <0d70270e-2290-47f4-87d1-9a11019fa169@nvidia.com> Content-Language: en-US In-Reply-To: <0d70270e-2290-47f4-87d1-9a11019fa169@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MA5P287CA0021.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:179::10) To CH8PR12MB9768.namprd12.prod.outlook.com (2603:10b6:610:260::9) Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR12MB9768:EE_|DM4PR12MB6422:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a429df9-ded8-4b89-345f-08ddcb9420c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?c1pFSXNtQjFXWlhPTUVhSWdwVWlhb0FMSFBGVUpIaFRCbTdNWmdSMVFzNGox?= =?utf-8?B?elY2ZU53c1lrWGc3ZVdzQytrN3lmL0tBYkpUUkc2UkFwU1JDWlJXWnRQUmQz?= =?utf-8?B?dnFUcW9EZXlFTDl1b2lKbmx1aWRZcEhyK01TWCt6bzZ1akNjdzJkemRrcll6?= =?utf-8?B?SVZON3Y1enhpSWxmRUZrTFVQajQ0NEhyWC9RR29HVTdJN2ExblZmSlhTYzRi?= =?utf-8?B?cmZFeDg0Uk5aeFhyZFNxVEFqeGlqcTU2QWVSTFZOdkhBeEViZUtjRVorVHBK?= =?utf-8?B?WjdSZ0FLc2gwYTJSOUxtTVJ4bHV6eDRyMW01aVI2YUtkbkVkamd5VEpEeXdn?= =?utf-8?B?a3F0d3d2anVTZHV0YkFNaGFrUHVEaEdITlMycnZnL1FoWVp1N2dkS2Y3bi85?= =?utf-8?B?RE42dGRqaDFuM2gyTmJhVGdtdXNsYitmamJOenlSVURRVFI4RDZvV0g2Yy9X?= =?utf-8?B?SE9BMUZxbG9Xc2NOMG9OYTAyODJMM2l0amc4a0FteGc0NTF4Q21FVnNPblhl?= =?utf-8?B?MFpBemViT2RXRlJrL2R6RXRja3ZjSlVnV01Ob0xEaGExSU5EenZtRWRNaDRS?= =?utf-8?B?b3YyQzVHLzhqUTd5dS9FS3dNWDhKUWdyM2xpUGNidlR1aFNPdFAwbEh4Qi9Y?= =?utf-8?B?d3hjN1JNV250ZXVaS1FWbWRabjdtamZMbjNnUy9OTGpoSExncmpaUm8wVVM2?= =?utf-8?B?ODNBQkdZcklLOFBvRjBhZUkvVWhEM3p4alJ0OWJuS3pQMk0yazk5MkM5amgv?= =?utf-8?B?SGEzTHVZd0pkK0FGRStKQzI0eUdvUXl3RHkzNVVEL0NtT1R6MlF2a2NMUFV1?= =?utf-8?B?eEJqZzFpOW9KYnlZbTRXWExTd0g2MmdOb0xNR2dYWVg5dzRWaEE0UGhOMkVF?= =?utf-8?B?WDBENmhGbXBBWWx3eXEyd2lpd1k0M3dtSEVhNndHZjRTM2JEMi9helgzUlc1?= =?utf-8?B?Rk94VENLNU0rZHpEU2FlK2U0L0w0OGYyWjVvNm5rdlFpOS9FK0VmdEpWdWRS?= =?utf-8?B?UU9BWjN4R2FzZE9VSFQ2VDNZYms3bmMyVWE3bXhhV0twMmx6L2ZYWURuVjI1?= =?utf-8?B?MXcxT2JYZVZKRkxuRXdFSWpqL0dWbHdtLzBIZHBhVDR3QWtqWjRLRWdnbTRM?= =?utf-8?B?ZlNoaC92MFpyN1NocmozYTYvcm1yN0VQN0pJR20yR0M0ZE9HMFhTUW5Wd3RX?= =?utf-8?B?dmI0cmQ2OUhxeklmZnhpVnhwRmFiYVNkOXBkK2R6Q0JxYjU5VVduVWNyYkVH?= =?utf-8?B?Q0ozcHg2blJtY2ViaS90WVRneHlvelgrRjBDQ2hkLzkyeStDWncxTDNWa0x0?= =?utf-8?B?ZEI5SzJOdDJvZnpxUllpVllVMHJaV2twSTNtRmxURDh0YThFZ2p3U0NqT2NY?= =?utf-8?B?YjF3dE5ENkNvSVhxT243aHpFRFc0d0duZUJEbitoMXlpWHFHTkordng5NmdE?= =?utf-8?B?Tlk4ekVBTnByQnphSmRNeTBHUm9DR1JxbUs1RzhTS0ZkZEEyWmxya2tITUdv?= =?utf-8?B?dFNZaVRzUjBRZXhmOEZBOEJieUF6TW1QSmNsWk5MYmRXZVFqZm0yblBhUm5m?= =?utf-8?B?RGJubHNyM1BVUU5LQnVXVHQ5NGlNMC9DZkdNczVrQzlTMVJRRFhWRG5FS2VC?= =?utf-8?B?UkY4WC91ckpUS2tWOUxvTFV1VFNRSSt3RHErY0trTXRzUko4Z2VCamZKa0p0?= =?utf-8?B?MEVkMXE1enBoa0c5c3RpNlJublBBbHJWSWpqUVVHd0gzdWU4WXMrcCtodU1M?= =?utf-8?B?MGphbXVXUXJoZFRMYXVNL3JLemVhZis1bEVkWlpIQ0h3M2VnMTlXWVZCTTEr?= =?utf-8?B?VVJCRVpEcEJ0S0FYU0lnWGdyRDBveWJxcGQzMTJZWncxZlc0ZDBFY3BUdlY3?= =?utf-8?B?L3h4SC9wRnlBYmlscFppbEVOTFU1MXpxVlAvcjlLQVFLeXNMVGVKWkZhUmVH?= =?utf-8?Q?okSazaeJNjE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR12MB9768.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K29NdWJLWHN2TTlGa3dSWDZDYWhjN3hNcDRqYUpZQVN5TUVqcmsyNHZDdGYv?= =?utf-8?B?d2xrVTlPRE9YUVY3Lzd2VkhTUUROZm5YajN5SXErWDJMRDZ6NHQ1QUNxcGFT?= =?utf-8?B?UE55Wi91Z0JQNkFPYTdKam05bHVzT0ZEK2RsZTdKV28zY1lEVTd2L1N0emgw?= =?utf-8?B?Z0NyRjFTSzllSFE1NGR3VWxWd1J6My9xdW4rd2RiQkxWdVBZQ1VxN3lDS2FU?= =?utf-8?B?ZEhPbllKSUtsQ0ozSDJ4UlgzZHhqNE9UTVFWdlBneFRTdGJDcXp1VW9NUmc4?= =?utf-8?B?WWtWNGh3Vnc1Unc4dkU0bGVhdm5qeEVjY0VlelZvK0hqVUNUendjTFVaZGRN?= =?utf-8?B?WGc5enM0WEdRZEtScmtZbHlNT0hvUTBiV1FINXp6a3JjUXRCOURHS09ZbzhX?= =?utf-8?B?OFFLM3JrNW1mYXUrZWpHSy9FeEh1NTYvNGIzUGNZOUQ2cGtSRGVJVy9RWnh3?= =?utf-8?B?MGkxNzNhdjZYN0c1ZE9PZ3pTNStFWUxLUmYyd2pEY0tTNkFLUWhZTEl2MDlp?= =?utf-8?B?YkxudzZnNEpuV1h4ZjF3bDNXTkxBWFRKTDVIZUpXQkZkcFdVZzFJRmh1cDlJ?= =?utf-8?B?Ujk0eHRFZnRGL0pDQWY2Y0lFTE5wS2JsdlZ1aEFDdm1CV3J4SEQrWHdtL1or?= =?utf-8?B?WlE4c3lkeVZtbzBjVGVKM01jTytjdzgwOXBWYTNFRlhGV0dERTJQa1R6bStE?= =?utf-8?B?Sm9MVTBxOE5JSzduRUVWYkRPc3lVTi9UcTlqNWZjOW1UeXhLUUVBekFPR3ZR?= =?utf-8?B?SWRjMzBoTTVJVUhHb2czZnZBN1I5M3p2bW5BWVVDelcrbTlCeC9MUkw3bXQ5?= =?utf-8?B?Q3hvbmFZS2FzWlJDaHdjT1JzMkdnQVlOWmd2ZVp2NzBQaVNJTk1oQlUzNUJE?= =?utf-8?B?UklBd3hZYmxDcFFlZzFDbmJkdnRFekxyRm1iL2N4eGozaVZkRDVtZTZ3NlNv?= =?utf-8?B?LzNxMGduRzJhbHh2Ym8xelo1WnNzU2hzeEdUTlVCRk1uV3Uvay8wWDlLVEtR?= =?utf-8?B?NzB0Zyt1RTU1dlVPZjAzU3R4K0RYcUFaNTZXSWcwaGV5dlZuZldFT2xIbG81?= =?utf-8?B?V2g1enRNdjNVQUJDeVM3NXNjMWJvcURWUURseHlWclR4L2ZOMDBHbzVuMGd3?= =?utf-8?B?bEN2dDFxbTBmbGQ0U0dZSGltL081UWQrN3RkSTBZTjRsRUJsYmNVekFUWk4r?= =?utf-8?B?Z1UzT3BIZ2ZHOVFLNjNvcDBtdHpoNmtOVmRBVUdNVVJKYTZ0UVQwTEFKSmtQ?= =?utf-8?B?VjBRWGtINkxLeUhrTFA1L01PbWhIS0w2SWdvNXJIdnhWc1lBVyt2UVJiUlpy?= =?utf-8?B?b2s5eURadlFRVStPeTQybmNzZnhHVEJWemFXaG41RUxWTi9jWFlyVUdYdUpN?= =?utf-8?B?cHE4ZFl2bFRsOTh3ME1tanJQcDhHU0FvTmd6Y21kMFQ1bFhFRGNQNXMyZTIy?= =?utf-8?B?UHVFMDVGYVZacjdSY3lPNDNuMGllaTBtTGNWMzNrUllYSHlYU2U5QUNBdUt3?= =?utf-8?B?MU9zbXhPV0VMYkV1Z2tNNSt3YVdmNGU1Z01UOGlYaHhKVWFSQkFYN1FSRFpU?= =?utf-8?B?YkYwd1dYY0R6UkUyZTFLNHpQNXNPSkQvOUtnVnNHQ2UxeWR5d2RIMzRoYitE?= =?utf-8?B?TlY2aURhalRiUFdLcy95VlZzOCtCdktTeVhiUEh0eTVDU0JVREdXM28wY3JO?= =?utf-8?B?S2JLMTdjbzNQL0xIR0RyYmJWV05hSm8zYXVRdzRsUVZWM0JqVVJ6ay9GYTZJ?= =?utf-8?B?TG05TG5SZHJ5TkZLQjFIQlZqR1dxeUcvRnJzZjNWbEQ4TGswRngwNHB4NTJ5?= =?utf-8?B?Q0cwRWFZUE9Jc0RlTWFTS0IzbTFZajlQNFdQNWUwaHNuOElLWXRxaUZvcVdQ?= =?utf-8?B?T3ZGUTV2NSt2UlBrM21vU3c2QUxkWXl0N3V5RUQvLzJTaS9ud2FXTk1zUngx?= =?utf-8?B?blVMdjVWYjhTcXZFc000Rm1xZ2xuV1pjRmIzRVhaczRQMEJwYWtrbnNTOEJh?= =?utf-8?B?U1Fya1FyOERtMXFXVThXMXlMZjQzYllxc1JZQUNJZm1USW81cWkrMHdVcVE1?= =?utf-8?B?cWkyVFdqWGNteHRzZTNYbHpDZUIxMFZsR2RBMUZwaVNYbkJHV3ZoRU9XQ0N6?= =?utf-8?Q?f402PDAts2SchBl7m1/1FH9Wt?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a429df9-ded8-4b89-345f-08ddcb9420c3 X-MS-Exchange-CrossTenant-AuthSource: CH8PR12MB9768.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 15:58:45.9722 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JCMPXHG/o+HqoX3gHJDk0+eyBhn/WPBMVBL6RR8dX/4At5nO0msSi6lzwh0qC61nIlCovXS66iekoiRNxgqLKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6422 On 24/07/25 4:20 pm, Jon Hunter wrote: > > On 24/07/2025 11:06, Krzysztof Kozlowski wrote: >> On 24/07/2025 11:41, Jon Hunter wrote: >>> >>> On 24/07/2025 08:59, Krzysztof Kozlowski wrote: >>>> On Wed, Jul 23, 2025 at 01:03:40PM +0000, Shubhi Garg wrote: >>>>> +description: >>>>> +  NVIDIA VRS (Voltage Regulator Specification) RTC provides 32kHz >>>>> RTC clock >>>>> +  support with backup battery for system timing. It provides alarm >>>>> functionality >>>>> +  to wake system from suspend and shutdown state. The device also >>>>> acts as an >>>>> +  interrupt controller for managing interrupts from the VRS. >>>>> + >>>>> +properties: >>>>> +  compatible: >>>>> +    const: nvidia,vrs10-rtc >>>> >>>> Nothing improved. You never replied to comments and then replaced one >>>> redundant word into other redundant word. >>>> >>>> Respond to review or implement it fully, not partially. >>>> >>>> Or add COMPLETE bindings, not partial ones. See writing bindings doc. >>> >>> OK, right so the DT binding should describe the overall PMIC device, >>> even though the driver needs to support the RTC. VRS-10 is the device name. VRS-10 has an I2C interface and implements a power sequencer, RTC , 32kHZ clock output. From software perspective, we are handling VRS-10 interrupts and providing RTC driver support. I will add complete VRS-10 information in bindings. >> >> This is not a driver patch. This is patch for hardware. Sending >> incomplete pieces of a device, without complete picture is really not >> the right way. Knowing this is part of PMIC this should be rejected, but >> how can we decide on that if contributor never tells us this is a part >> of PMIC? > > Yes I understand that this is not a driver patch and must describe the > hardware. It is a simple misunderstanding because it was rejected as an > MFD, but we should not have then made the DT look like only a RTC > device. This is a mistake on our side and we will fix. > I acknowledge, will improve bindings by describing VRS-10 hardware for clear understanding. -- Regards, Shubhi