From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11816127E3B for ; Tue, 16 Apr 2024 10:56:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713265007; cv=none; b=bVGoNaJAgNYxsslG61x3Cycz1AEFWneFV3EW8YuVl7SdWSgEJOjtfdJ3RyS2QS5veFvtcyQvQ5zZiBMIkEneccrcc/JSjjnUcOtd41IJJ0C/7XwgUHz+EPhallXnTgXR+u3NUawYsojvHmw3Ujd0ZPK44s0k1OFlM4BQWlx+Cnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713265007; c=relaxed/simple; bh=HlgZk8CvLNHX7j9hSVFcL16+f4dTN36eZ1Z1lh6hhAU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D9hMlr0er1hLKoo0LYcBxya/M30+xoaJqUevLzDNG38Lfammfreaf0znlMLdz0/zzZRFOjQGPSo1DdGTyhoMDQl/p4Ii/HchJgOZ+w3pB7QiX80BNHwq0vnoVNLj0E0nSH9Xg+kJPyX65mhdlLDT2hvErvvebkDECsfVD5Vm3h4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=r6U+yINx; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="r6U+yINx" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-56e48d0a632so6704792a12.2 for ; Tue, 16 Apr 2024 03:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713265003; x=1713869803; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5+LvTU+20katiBQPmXC4bjjTw0g5f/3WkUMY6Jo3I4w=; b=r6U+yINxFACDakQy+03qXcj6VxcD4ap5W6Fk62p4c94V5dKPPnAfxE9+WeQQAhSKMP OjMOuV4kG4Nxhf3BZJ3hDdbVm8YZXmrxrbukZ5A32VIoBbou1Dl0QUJxQBGbudJ5cOyk tkSEfcXBkU5CbgvbBGpthGz9MLvUIP8yuzUrXDln/SzxdUmEEvy9j2qPpN3nbzRdC+nJ VeNx0lNPgcfsDbp1/XOvYpvREbcMVl9Kk58KHfkQ3Q1wRgfqgnF0rF6E8Cnh0fAS2h25 Trk0BO7Uo8Jbb0eQ65TlHWPmzAI+ZHbbth42IbF1GJG1WIRhW1NF+1lJGq3R/FzGGPNh oMnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713265003; x=1713869803; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5+LvTU+20katiBQPmXC4bjjTw0g5f/3WkUMY6Jo3I4w=; b=PTomW4tVfTc47qac16w6r3DFaj8KoruYaWNrbRswDShHqdg5Pu3l6SVmdShjeuZ1GU T/EJn9d8+WOMLGbG0w5UjDtRhthysijqBKbmF5Kk9VsBldBwRE8DmpsZkA9T4RzqPRZe my5QjPn3stvfIW3xmZmpetb/1f3WcaxMdU+bKI97dSZUe/QVa1xK9twOrIQcvWJ9zvmP VDZO14VfYcuQasx8EfNdD3PXbz3yLiKmP7wsbnpXJGoc2BFk5YWsWq514kzv5g/i8GiL 44UDVjZby2byhfcQ7i/G3tfvHx9dt+Af+cWAnjjxdkGU6N4gdGQw+rnIn1+QqSpcKgMR R0ww== X-Forwarded-Encrypted: i=1; AJvYcCXVyc4hjt8kBUwi7ZFccHWnMDzlV4xqv2NY7YC/9sZI5W5gSo4617ozXepklactIWtYvLKWTigrYYs4NgNyyfLY9ui7an1lb9PtCtk= X-Gm-Message-State: AOJu0YyriTzrps9LTgsnB/I9HLFnEB+A+TQ5/cGzdEJS4cp4u35QQq3v uuTVH1aILbstmSYb63uifP6QsCmywStYHq5V2gM0yqlHI/UAxPnSBrnKTeybYyA= X-Google-Smtp-Source: AGHT+IFRHzwHYV/k15VsjWZfN2SFFrEwWZL3WX+T78lKXGwI5ZHOHbWBE7IZ649XfmZzZPkChlPXBw== X-Received: by 2002:a50:8d19:0:b0:570:1161:111f with SMTP id s25-20020a508d19000000b005701161111fmr8339541eds.15.1713265003274; Tue, 16 Apr 2024 03:56:43 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id u5-20020aa7d985000000b0057000a2cb5bsm4692942eds.18.2024.04.16.03.56.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 03:56:42 -0700 (PDT) Date: Tue, 16 Apr 2024 13:56:38 +0300 From: Dan Carpenter To: Ricardo Ribalda Cc: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Pavel Machek , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 23/35] media: dvb-frontends: tda10048: Use the right div Message-ID: References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240415-fix-cocci-v1-23-477afb23728b@chromium.org> <97f51ae8-6672-4bd4-b55b-f02114e3d8d0@moroto.mountain> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 16, 2024 at 12:39:33PM +0200, Ricardo Ribalda wrote: > Hi Dan > > What about going the safe way? > > --- a/drivers/media/dvb-frontends/tda10048.c > +++ b/drivers/media/dvb-frontends/tda10048.c > @@ -341,7 +341,7 @@ static int tda10048_set_wref(struct dvb_frontend > *fe, u32 sample_freq_hz, > /* t *= 2147483648 on 32bit platforms */ > t *= (2048 * 1024); > t *= 1024; > - z = 7 * sample_freq_hz; > + z = (u64)7 * sample_freq_hz; I think your patch works, but it might be nicer without the casts. We end up having the discussion where it's like "Can this hz be above 4GHz?" And, here, I think we're safe but a lot of stuff is pushing up against that limit these days... regards, dan carpenter