From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mikko Perttunen <mperttunen@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: Svyatoslav Ryhel <clamor95@gmail.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v2] memory: tegra: Deduplicate rate request management code
Date: Tue, 28 Apr 2026 11:12:12 +0200 [thread overview]
Message-ID: <bd17f11f-12ce-46e0-a743-3fbc51b94d97@kernel.org> (raw)
In-Reply-To: <20260417-memory-refactor-v2-1-1669de38798f@nvidia.com>
On 17/04/2026 11:19, Mikko Perttunen wrote:
> +
> +struct tegra_emc_rate_request {
> + unsigned long min_rate;
> + unsigned long max_rate;
> +};
> +
> +struct tegra_emc_rate_requests {
> + struct tegra_emc_rate_request requested_rate[TEGRA_EMC_RATE_TYPE_MAX];
> + struct mutex rate_lock;
You introduced a new checkpatch warning. Wasn't there before. Probably
the old comment feels to obvious in this context, so it should be
extended to be meaningful, e.g. what data structure, which members,
which code paths etc.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-28 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 9:19 [PATCH v2] memory: tegra: Deduplicate rate request management code Mikko Perttunen
2026-04-28 9:12 ` Krzysztof Kozlowski [this message]
2026-04-30 6:52 ` Mikko Perttunen
2026-04-30 7:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd17f11f-12ce-46e0-a743-3fbc51b94d97@kernel.org \
--to=krzk@kernel.org \
--cc=clamor95@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox