From: Haotien Hsu <haotienh@nvidia.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: <p.zabel@pengutronix.de>, <jckuo@nvidia.com>, <kishon@ti.com>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<linux-phy@lists.infradead.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Wayne Chang <waynec@nvidia.com>
Subject: Re: [PATCH] phy: tegra: xusb: Enable usb role switch attribute
Date: Mon, 26 Sep 2022 13:00:04 +0800 [thread overview]
Message-ID: <be78f14b-3b76-84be-c374-d5b7b7794402@nvidia.com> (raw)
In-Reply-To: <Yy6u+9x/oDo4Gd+F@matsya>
On 9/24/22 15:17, Vinod Koul wrote:
> On 21-09-22, 19:25, Haotien Hsu wrote:
>> From: Wayne Chang <waynec@nvidia.com>
>>
>> This patch enables the usb-role-switch atrribute
>> to have the user-space check current device role
>> of otg cability ports
>
> typo cability
>
>
> You can use 72 chars for changelog rather than limiting at 50chars :-(
>
Sorry for the typo and bad format.
I will resend this patch.
>>
>> Signed-off-by: Wayne Chang <waynec@nvidia.com>
>> Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
>> ---
>> drivers/phy/tegra/xusb.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
>> index aa5237eacd29..220ab7719ade 100644
>> --- a/drivers/phy/tegra/xusb.c
>> +++ b/drivers/phy/tegra/xusb.c
>> @@ -656,6 +656,7 @@ static int tegra_xusb_setup_usb_role_switch(struct tegra_xusb_port *port)
>> struct usb_role_switch_desc role_sx_desc = {
>> .fwnode = dev_fwnode(&port->dev),
>> .set = tegra_xusb_role_sw_set,
>> + .allow_userspace_control = true,
>> };
>> int err = 0;
>>
>> --
>> 2.25.1
>
prev parent reply other threads:[~2022-09-26 5:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 11:25 [PATCH] phy: tegra: xusb: Enable usb role switch attribute Haotien Hsu
2022-09-24 7:17 ` Vinod Koul
2022-09-26 5:00 ` Haotien Hsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be78f14b-3b76-84be-c374-d5b7b7794402@nvidia.com \
--to=haotienh@nvidia.com \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
--cc=waynec@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox