From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 421F72ECD20; Fri, 4 Jul 2025 09:18:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751620714; cv=none; b=WiPgWCkYAS/QT257RmtWpSeKvh09QeVzAgYmNysu8MTVzoYqM/4NodfIXHn15cYOqnZV+oYJAm5yOmP+sECFZTOXQNo74cb/Qo3X6q03ngm8Gxzs8V7XiOBXmh7Gqxx5Qr/ALbOSfTLCpuFCTt4hNTKSZ6w3p/kdVCL1BHWlgqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751620714; c=relaxed/simple; bh=uakiFyp8ZePVF1tgBOYg2Xyh8hf0lWhL5NbjyXQ+1Go=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CC9BlIT90vid2Z58apSGpZHhuB6AOY5UWLomCEgWrc+tlLmdSNIuJcZG0aXh6pALE9EE523nevXeT677boRpmSZ0I/KKmq+ZERLWt6Aqy+XElmcItJwiaZa3Q6msz89oDcPaHvWN2pQ0hDQOJP8/Q83+E+2Z5bdhukgAxd4TBY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 99536153B; Fri, 4 Jul 2025 02:18:17 -0700 (PDT) Received: from [10.1.39.21] (e122027.cambridge.arm.com [10.1.39.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DEB0C3F6A8; Fri, 4 Jul 2025 02:18:23 -0700 (PDT) Message-ID: Date: Fri, 4 Jul 2025 10:18:19 +0100 Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 20/80] drivers: drm: Remove redundant pm_runtime_mark_last_busy() calls To: Sakari Ailus , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Douglas Anderson , Lucas Stach , Russell King , Christian Gmeiner , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Laurentiu Palcu , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Qiang Yu , Jessica Zhang , Boris Brezillon , Liviu Dudau , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jyri Sarha , Tomi Valkeinen , Dave Stevenson , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Dmitry Baryshkov , Damon Ding , Ayushi Makhija , Luca Ceresoli , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Chen-Yu Tsai Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, imx@lists.linux.dev, lima@lists.freedesktop.org, linux-tegra@vger.kernel.org References: <20250704075225.3212486-1-sakari.ailus@linux.intel.com> <20250704075413.3218307-1-sakari.ailus@linux.intel.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20250704075413.3218307-1-sakari.ailus@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04/07/2025 08:54, Sakari Ailus wrote: > pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), > pm_runtime_autosuspend() and pm_request_autosuspend() now include a call > to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to > pm_runtime_mark_last_busy(). > > Signed-off-by: Sakari Ailus > --- > The cover letter of the set can be found here > . > > In brief, this patch depends on PM runtime patches adding marking the last > busy timestamp in autosuspend related functions. The patches are here, on > rc2: > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ > pm-runtime-6.17-rc1 > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 -- > drivers/gpu/drm/bridge/analogix/anx7625.c | 2 -- > drivers/gpu/drm/bridge/parade-ps8640.c | 2 -- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 - > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 ---- > drivers/gpu/drm/exynos/exynos_drm_fimc.c | 2 -- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 -- > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 -- > drivers/gpu/drm/exynos/exynos_drm_rotator.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_scaler.c | 1 - > drivers/gpu/drm/i915/intel_runtime_pm.c | 2 -- > drivers/gpu/drm/imx/dcss/dcss-crtc.c | 1 - > drivers/gpu/drm/lima/lima_sched.c | 1 - > drivers/gpu/drm/panel/panel-edp.c | 3 --- > drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 2 -- > drivers/gpu/drm/panel/panel-simple.c | 2 -- > drivers/gpu/drm/panthor/panthor_sched.c | 2 -- Panthor changes are: Reviewed-by: Steven Price Thanks, Steve > drivers/gpu/drm/tegra/submit.c | 1 - > drivers/gpu/drm/tidss/tidss_drv.c | 2 -- > drivers/gpu/drm/vc4/vc4_v3d.c | 1 - > 20 files changed, 36 deletions(-) > [...] > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index a2248f692a03..f635f26a23f4 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -2446,7 +2446,6 @@ static void tick_work(struct work_struct *work) > > out_unlock: > mutex_unlock(&sched->lock); > - pm_runtime_mark_last_busy(ptdev->base.dev); > pm_runtime_put_autosuspend(ptdev->base.dev); > > out_dev_exit: > @@ -3203,7 +3202,6 @@ queue_run_job(struct drm_sched_job *sched_job) > > out_unlock: > mutex_unlock(&sched->lock); > - pm_runtime_mark_last_busy(ptdev->base.dev); > pm_runtime_put_autosuspend(ptdev->base.dev); > > return done_fence;