Re: [PATCH] drm/tegra: output: Do not put OF node twice

[Dmitry Osipenko <digetx@gmail.com>]

13.11.2020 23:41, Thierry Reding пишет:
> From: Thierry Reding <treding@nvidia.com>
> 
> The original patch for commit 3d2e7aec7013 ("drm/tegra: output: Don't
> leak OF node on error") contained this hunk, but it was accidentally
> dropped during conflict resolution. This causes use-after-free errors
> on devices that use an I2C controller for HDMI DDC/CI on Tegra210 and
> later.
> 
> Fixes: 3d2e7aec7013 ("drm/tegra: output: Don't leak OF node on error")
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/gpu/drm/tegra/output.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c
> index 5a4fd0dbf4cf..47d26b5d9945 100644
> --- a/drivers/gpu/drm/tegra/output.c
> +++ b/drivers/gpu/drm/tegra/output.c
> @@ -129,7 +129,6 @@ int tegra_output_probe(struct tegra_output *output)
>  
>  		if (!output->ddc) {
>  			err = -EPROBE_DEFER;
> -			of_node_put(ddc);
>  			return err;
>  		}
>  	}
> 

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>