From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <treding@nvidia.com>
Cc: "Laxman Dewangan" <ldewangan@nvidia.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Michał Mirosł aw" <mirq-linux@rere.qmqm.pl>,
dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 00/13] NVIDIA Tegra APB DMA driver fixes and improvements
Date: Wed, 8 Jan 2020 18:07:46 +0300 [thread overview]
Message-ID: <c68cde59-0571-f58f-bf3c-8ce1cbdcc387@gmail.com> (raw)
In-Reply-To: <85d8ea335734417081399a082d44024c@HQMAIL105.nvidia.com>
08.01.2020 15:51, Thierry Reding пишет:
> On Mon, 06 Jan 2020 04:16:55 +0300, Dmitry Osipenko wrote:
>> Hello,
>>
>> This is series fixes some problems that I spotted recently, secondly the
>> driver's code gets a cleanup. Please review and apply, thanks in advance!
>>
>> Changelog:
>>
>> v3: - In the review comment to v1 Michał Mirosław suggested that "Prevent
>> race conditions on channel's freeing" does changes that deserve to
>> be separated into two patches. I factored out and improved tasklet
>> releasing into this new patch:
>>
>> dmaengine: tegra-apb: Clean up tasklet releasing
>>
>> - The "Fix use-after-free" patch got an improved commit message.
>>
>> v2: - I took another look at the driver and spotted few more things that
>> could be improved, which resulted in these new patches:
>>
>> dmaengine: tegra-apb: Remove runtime PM usage
>> dmaengine: tegra-apb: Clean up suspend-resume
>> dmaengine: tegra-apb: Add missing of_dma_controller_free
>> dmaengine: tegra-apb: Allow to compile as a loadable kernel module
>> dmaengine: tegra-apb: Remove MODULE_ALIAS
>>
>> Dmitry Osipenko (13):
>> dmaengine: tegra-apb: Fix use-after-free
>> dmaengine: tegra-apb: Implement synchronization callback
>> dmaengine: tegra-apb: Prevent race conditions on channel's freeing
>> dmaengine: tegra-apb: Clean up tasklet releasing
>> dmaengine: tegra-apb: Prevent race conditions of tasklet vs free list
>> dmaengine: tegra-apb: Use devm_platform_ioremap_resource
>> dmaengine: tegra-apb: Use devm_request_irq
>> dmaengine: tegra-apb: Fix coding style problems
>> dmaengine: tegra-apb: Remove runtime PM usage
>> dmaengine: tegra-apb: Clean up suspend-resume
>> dmaengine: tegra-apb: Add missing of_dma_controller_free
>> dmaengine: tegra-apb: Allow to compile as a loadable kernel module
>> dmaengine: tegra-apb: Remove MODULE_ALIAS
>>
>> drivers/dma/Kconfig | 2 +-
>> drivers/dma/tegra20-apb-dma.c | 481 ++++++++++++++++------------------
>> 2 files changed, 220 insertions(+), 263 deletions(-)
>
> Test results:
> 13 builds: 13 pass, 0 fail
> 12 boots: 11 pass, 1 fail
I'm not sure how to interpret this result. Could you please explain what
that fail means?
> 38 tests: 38 pass, 0 fail
>
> Linux version: 5.5.0-rc5-gf9d40c056c0f
> Boards tested: tegra20-ventana, tegra30-cardhu-a04, tegra124-jetson-tk1,
> tegra186-p2771-0000, tegra194-p2972-0000,
> tegra210-p2371-2180
>
Will be awesome to see the detailed testing results, at least console
log like it was with NVTB.
next prev parent reply other threads:[~2020-01-08 15:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 1:16 [PATCH v3 00/13] NVIDIA Tegra APB DMA driver fixes and improvements Dmitry Osipenko
2020-01-06 1:16 ` [PATCH v3 01/13] dmaengine: tegra-apb: Fix use-after-free Dmitry Osipenko
2020-01-06 1:16 ` [PATCH v3 02/13] dmaengine: tegra-apb: Implement synchronization callback Dmitry Osipenko
2020-01-06 1:16 ` [PATCH v3 03/13] dmaengine: tegra-apb: Prevent race conditions on channel's freeing Dmitry Osipenko
2020-01-06 1:16 ` [PATCH v3 04/13] dmaengine: tegra-apb: Clean up tasklet releasing Dmitry Osipenko
2020-01-06 1:17 ` [PATCH v3 05/13] dmaengine: tegra-apb: Prevent race conditions of tasklet vs free list Dmitry Osipenko
2020-01-06 1:17 ` [PATCH v3 06/13] dmaengine: tegra-apb: Use devm_platform_ioremap_resource Dmitry Osipenko
2020-01-06 1:17 ` [PATCH v3 07/13] dmaengine: tegra-apb: Use devm_request_irq Dmitry Osipenko
2020-01-06 1:17 ` [PATCH v3 08/13] dmaengine: tegra-apb: Fix coding style problems Dmitry Osipenko
2020-01-06 1:17 ` [PATCH v3 09/13] dmaengine: tegra-apb: Remove runtime PM usage Dmitry Osipenko
2020-01-07 15:13 ` Jon Hunter
2020-01-07 17:12 ` Dmitry Osipenko
2020-01-07 18:38 ` Jon Hunter
2020-01-08 15:10 ` Dmitry Osipenko
2020-01-10 8:05 ` Vinod Koul
2020-01-06 1:17 ` [PATCH v3 10/13] dmaengine: tegra-apb: Clean up suspend-resume Dmitry Osipenko
2020-01-06 1:17 ` [PATCH v3 11/13] dmaengine: tegra-apb: Add missing of_dma_controller_free Dmitry Osipenko
2020-01-06 1:17 ` [PATCH v3 12/13] dmaengine: tegra-apb: Allow to compile as a loadable kernel module Dmitry Osipenko
2020-01-06 1:17 ` [PATCH v3 13/13] dmaengine: tegra-apb: Remove MODULE_ALIAS Dmitry Osipenko
2020-01-08 12:51 ` [PATCH v3 00/13] NVIDIA Tegra APB DMA driver fixes and improvements Thierry Reding
2020-01-08 15:07 ` Dmitry Osipenko [this message]
[not found] ` <c68cde59-0571-f58f-bf3c-8ce1cbdcc387-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-09 10:04 ` Thierry Reding
2020-01-09 14:24 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c68cde59-0571-f58f-bf3c-8ce1cbdcc387@gmail.com \
--to=digetx@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox