From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nick Alcock <nick.alcock@oracle.com>, mcgrof@kernel.org
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 15/27] memory: tegra: remove MODULE_LICENSE in non-modules
Date: Mon, 6 Mar 2023 15:30:17 +0100 [thread overview]
Message-ID: <c6f39365-e840-d782-8ec0-e34ec3681b98@linaro.org> (raw)
In-Reply-To: <20230224150811.80316-16-nick.alcock@oracle.com>
On 24/02/2023 16:07, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
Applied as well. Squashed with next one. Same subject messes with b4, so
prefix should be corrected if these were to stay as separate patches.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-06 14:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230224150811.80316-1-nick.alcock@oracle.com>
2023-02-24 15:07 ` [PATCH 15/27] memory: tegra: remove MODULE_LICENSE in non-modules Nick Alcock
2023-03-06 14:30 ` Krzysztof Kozlowski [this message]
2023-03-06 15:45 ` Krzysztof Kozlowski
2023-03-06 17:13 ` Nick Alcock
2023-03-06 18:25 ` Krzysztof Kozlowski
2023-03-08 20:25 ` Nick Alcock
2023-03-09 6:19 ` Krzysztof Kozlowski
2023-02-24 15:08 ` [PATCH 16/27] " Nick Alcock
2023-03-06 14:28 ` (subset) " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6f39365-e840-d782-8ec0-e34ec3681b98@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=hasegawa-hitomi@fujitsu.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nick.alcock@oracle.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox