From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 254C01B040B for ; Wed, 29 Jan 2025 15:43:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738165435; cv=none; b=uK2Po2FXLri3/Mk+C4d8TNHnqHqQGkHxh1dQVo0L2MKOgflLuuEkm0YnQR7ha7nKk4sB//nYFn1QXE8SMBDMzxW2ehH0Ew/CHBwnXRaXGIkYN5ZoFCKo5ajaoSEBC6VfrSMTB1HhZRNJYy3ysfRbuBeT6QoD7MEUxJuotfCAvZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738165435; c=relaxed/simple; bh=qg3GvwkSQaINnDplbY9Jxv9EAKxWtjMkn+E02u+EVuA=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=pktVj3hMIzT5/f8zyOyfIrTZqvezYfJyCCcUwhbEfp4nb7todKetBiecyD/8kZZfKzsvBptR4BvRxkVEIaZ4ceWVXFZaCAYf1qNEp/WoWZg2YztlwT7Jyk8+s5wNrXZxnOLXiE4N7IEsVpTp3Lzv9nqV0SZRHJxJEXZzYC3BW4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UBX1lpMK; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UBX1lpMK" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43626213fffso6048695e9.1 for ; Wed, 29 Jan 2025 07:43:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738165430; x=1738770230; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=hPHIr1AdUQXL4S8PLOw7faEqsccJFgDRWTAC+UQvuk0=; b=UBX1lpMK95dcGcyWpaE8//OpfKmXtVX2+2oarTYW6VNywO57OguXIVJsjRwlf/fZVL ZrKcGr5/HT0gM3emRYX8SgtV5WiyQzfZY+3yDLHZl5kaLLioWZT+ywfNvnjJ2FgjgUs4 uB3x4iHO9d4vPU/mFcq5+k/RBOuL7oYgi88IJH91AY9e7EMPH1FkqlpdX+E56WFdQRP8 +R40W62RkuCx5EhGP2v4Oy6xmpBwmuVCPcuusawX/5WFlhWjv12wuJnN0AHBtJUQcny4 xGu5ZL6ZY9LDQ+zal9iZw/WmAt3DE6UI7UIDT7u82VhrnW9c5aJ8Thw05wiUoIGQFprO WxJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738165430; x=1738770230; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=hPHIr1AdUQXL4S8PLOw7faEqsccJFgDRWTAC+UQvuk0=; b=pxgnMVWrcdagBFmCBlWjeq470M4kCYB1tqGJz5yNOZ194/Mb87aSbMwkUfmMUdkn4z 1gx0YmOerqVAmEPmXMfBXsYVaG20xw2JnWAYCqERfbBCsaF2o7gwe2NJnfUrtLXlHC1X jVA7k3xmBQoFw1u8mYnM53f4ZjybidZliFsMt5wmodmR6ki5UuWRpWHOex64jSm5+i9P 4rf1PM34onnjnXsSNr6ueC973iVa6O+2zavzX4IM85kCpdUI/m28XMd81U3gUB12ij86 pjA4Ohge19LA7VRyAvGJcFnIudXrP9so7bjLI0E6BoR1aZpx5RVAfC+TRPgGFd6tD+oP LMzw== X-Forwarded-Encrypted: i=1; AJvYcCWWQvsL/Iku5AZEr1f5q+JQz5u1Z+n8pr+zZXZaQl769xijm5JsVXSTbr0t/i1lPLdbmNKMAN71TsOuPw==@vger.kernel.org X-Gm-Message-State: AOJu0YwqgYrBpt0qnAkInkhOo8O7I6c3Rtw+wNy1+0qXJ+ENNzxV4QDj hXwnaRH0KAp9Bvp6Mj3zD6LuaSAXUskRYq1O5jj4cOcjecXavj0AlE9K2EG9TXU= X-Gm-Gg: ASbGncuw+sV980UANL2FeYjJUyBRKeLbrsynA2UY8NEumZJS8an9PrI9jdSkfKx6BFP AmrDxvQyOGm1/4FefM3g8w+sacou1tn3XE6QiXlRQ0+6/fyCpN1VSAFIJy5q3qiZz7DxHhNTMSk 06/FhRfs3OrvWyMoC6+f9zBWPiSjPKOXLKqjJvfdts2qFMROvfcgW4/6U6023E40F+/cb5EekU7 Olzqkr2C2t7TU3Qe6VzqIUGnp0EGSUWZ2IUOHiyPn+3ggv/mRUHJWLb9VTEUOUxO+/+S4XYtPLA FvIO2PYEkVY0yTYik1H+Kx9Y1v327SSTQUkxop1rkb5DSc1/CvKu/eadlg211Oskie22 X-Google-Smtp-Source: AGHT+IG+AzLiMQGtSlFoPMZbCjyIVlZSwQQSJOvatG/rHgk08wCvQOFvIicCJd/sEzgRT/WR6JlERw== X-Received: by 2002:a05:6000:1f81:b0:38a:a019:30dd with SMTP id ffacd0b85a97d-38c50fe7e90mr3136677f8f.8.1738165430293; Wed, 29 Jan 2025 07:43:50 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:b25e:a614:863b:566e? ([2a01:e0a:982:cbb0:b25e:a614:863b:566e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a188689sm17390387f8f.48.2025.01.29.07.43.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2025 07:43:49 -0800 (PST) Message-ID: Date: Wed, 29 Jan 2025 16:43:48 +0100 Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 05/14] drm/meson: move to devm_platform_ioremap_resource() usage To: Maxime Ripard , Anusha Srivatsa Cc: Joel Stanley , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrew Jeffery , Stefan Agner , Alison Wang , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Marek Vasut , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Raphael Gallais-Pou , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Alexey Brodkin , Dave Stevenson , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Jonathan Corbet , linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, linux-doc@vger.kernel.org References: <20250128-cocci-memory-api-v1-0-0d1609a29587@redhat.com> <20250128-cocci-memory-api-v1-5-0d1609a29587@redhat.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/01/2025 16:40, Maxime Ripard wrote: > On Tue, Jan 28, 2025 at 05:29:29PM -0500, Anusha Srivatsa wrote: >> Replace platform_get_resource_byname + devm_ioremap >> with just devm_platform_ioremap_resource() >> >> Used Coccinelle to do this change. SmPl patch: >> @rule_3@ >> identifier res; >> expression ioremap; >> identifier pdev; >> constant mem; >> expression name; >> @@ >> -struct resource *res; >> ... >> -res = platform_get_resource_byname(pdev,mem,name); >> <... >> -if (!res) { >> -... >> -} >> ...> >> -ioremap = devm_ioremap(...); >> +ioremap = devm_platform_ioremap_resource_byname(pdev,name); >> >> Cc: Neil Armstrong >> Signed-off-by: Anusha Srivatsa >> --- >> drivers/gpu/drm/meson/meson_drv.c | 9 +-------- >> 1 file changed, 1 insertion(+), 8 deletions(-) >> >> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c >> index 81d2ee37e7732dca89d02347b9c972300b38771a..6c805805b7a7f675f8bb03944318972eb4df864e 100644 >> --- a/drivers/gpu/drm/meson/meson_drv.c >> +++ b/drivers/gpu/drm/meson/meson_drv.c >> @@ -184,7 +184,6 @@ static int meson_drv_bind_master(struct device *dev, bool has_components) >> const struct meson_drm_match_data *match; >> struct meson_drm *priv; >> struct drm_device *drm; >> - struct resource *res; >> void __iomem *regs; >> int ret, i; >> >> @@ -220,14 +219,8 @@ static int meson_drv_bind_master(struct device *dev, bool has_components) >> } >> >> priv->io_base = regs; >> - >> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hhi"); >> - if (!res) { >> - ret = -EINVAL; >> - goto free_drm; >> - } >> /* Simply ioremap since it may be a shared register zone */ >> - regs = devm_ioremap(dev, res->start, resource_size(res)); >> + regs = devm_platform_ioremap_resource_byname(pdev, "hhi"); > > Given the comment, this one should probably be skipped. > Yes please skip this one. Thanks, Neil > Maxime