Re: [PATCH V5 02/18] pinctrl: tegra: Add suspend and resume support

Dmitry Osipenko
2019-06-28T12:05:46Z

28.06.2019 14:56, Dmitry Osipenko пишет:
> 28.06.2019 5:12, Sowjanya Komatineni пишет:
>> This patch adds support for Tegra pinctrl driver suspend and resume.
>>
>> During suspend, context of all pinctrl registers are stored and
>> on resume they are all restored to have all the pinmux and pad
>> configuration for normal operation.
>>
>> Acked-by: Thierry Reding <treding@nvidia.com>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---

>> int tegra_pinctrl_probe(struct platform_device *pdev,
>> const struct tegra_pinctrl_soc_data *soc_data);
>> #endif
>> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra210.c b/drivers/pinctrl/tegra/pinctrl-tegra210.c
>> index 0b56ad5c9c1c..edd3f4606cdb 100644
>> --- a/drivers/pinctrl/tegra/pinctrl-tegra210.c
>> +++ b/drivers/pinctrl/tegra/pinctrl-tegra210.c
>> @@ -1571,6 +1571,7 @@ static struct platform_driver tegra210_pinctrl_driver = {
>> .driver = {
>> .name = "tegra210-pinctrl",
>> .of_match_table = tegra210_pinctrl_of_match,
>> + .pm = &tegra_pinctrl_pm,
>> },
>> .probe = tegra210_pinctrl_probe,
>> };
>>
>
> Could you please address my comments in the next revision if there will be one?
>

Also, what about adding ".pm' for other Tegras? I'm sure Jon could test them for you.